Skip to content

[libassert] add wasm support#52675

Merged
BillyONeal merged 4 commits into
microsoft:masterfrom
nickdademo:libassert_wasm
Jul 2, 2026
Merged

[libassert] add wasm support#52675
BillyONeal merged 4 commits into
microsoft:masterfrom
nickdademo:libassert_wasm

Conversation

@nickdademo

@nickdademo nickdademo commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version, or no changes were necessary.
  • Any fixed CI baseline and CI feature baseline entries are removed from that file, or no entries needed to be changed.
  • All patch files in the port are applied and succeed.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Exactly one version is added in each modified versions file.
@nickdademo

nickdademo commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Also added a PR upstream a few weeks ago for the patch added in this port: jeremy-rifkin/libassert#161
dg0yt
dg0yt reviewed Jul 1, 2026
View reviewed changes
Comment thread ports/libassert/emscripten-platform.diff
#undef IS_WINDOWS
#define IS_WINDOWS 1
-#elif defined(__linux)
+#elif defined(__linux) || defined(__EMSCRIPTEN__)

@dg0yt dg0yt Jul 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__linux__?

@nickdademo nickdademo Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch - should I patch here or try and get it upstream as well?

@dg0yt dg0yt Jul 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be improved upstream.
(But I was also wondering if emscripten might define __linux__.)

@nickdademo nickdademo Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me check that ;)

@nickdademo nickdademo Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked: emscripten does not define __linux__

@ricardoofnl ricardoofnl Jul 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked: emscripten does not define __linux__

yeah u right I also checked it
BillyONeal
BillyONeal approved these changes Jul 2, 2026
View reviewed changes

@BillyONeal BillyONeal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@BillyONeal BillyONeal merged commit 1f2f9fb into microsoft:master Jul 2, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@nickdademo @BillyONeal @dg0yt @ricardoofnl