Just a tracking issue for things that need to be cleaned up in subsequent PRs from #880 ; I plan to resolve these as I go along. In some sense, I'd also prefer if we can set up something where some tooling can be vigilant about these, so I've tried to classify issues I've noticed into various classes here.
Broad stuff that I think would probably benefit from some vigilance setup:
More specific to #880's code itself:
Stuff that needs more thought, and probably not in a set of cleanup PRs, but needs broader discussion about the #880 decisions:
Just a tracking issue for things that need to be cleaned up in subsequent PRs from #880 ; I plan to resolve these as I go along. In some sense, I'd also prefer if we can set up something where some tooling can be vigilant about these, so I've tried to classify issues I've noticed into various classes here.
Broad stuff that I think would probably benefit from some vigilance setup:
Fromimpls where it makes sense.Channelinstead ofT. Also, keep trait boundaries closer at the struct level or suchpub->pub(crate)->pub(super)-> private, wherever it makes sneseErrand have upper level be forced to panic on an internal irrecoverable thinguse std::envstyle module imports#cfg(test)]moduleMore specific to #880's code itself:
#[non_exhaustive]slotmapUnknown+#[non_exhasutive]is a recipe for confusion, cleanStuff that needs more thought, and probably not in a set of cleanup PRs, but needs broader discussion about the #880 decisions: