fix(react-headless-components-preview): apply state.arrowClassName in renderTooltip - #36668
Open
Ray Knight (ArrayKnight) wants to merge 1 commit into
Conversation
… renderTooltip renderTooltip rendered the arrow element with no className, silently discarding state.arrowClassName — a field the published Tooltip type contract declares and the Griffel renderer applies. Apply it, keeping the data-arrow attribute. Extracted from the windmod branch commit a2f2bc3 (headless hunk only). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Aj9uA3rCVgosnh2zNn8qkc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The headless
renderTooltiprenders the arrow element as<div ref={state.arrowRef} data-arrow="" />with noclassName, silently discardingstate.arrowClassName— a field the published Tooltip type contract declares (Tooltip.types.ts/react-tooltip.api.md), the Griffel renderer applies, anduseTooltipStyles.styles.tssets. A consumer or styling layer that sets it gets no error and no warning, just an unstyled arrow.The fix applies the field:
<div ref={state.arrowRef} className={state.arrowClassName} data-arrow="" />, matching the Griffel renderer the headless copy mirrors. One line; the field was previously inert, so no existing render output changes unless a consumer was already setting a value that was being thrown away.Fixes #36650.
Extracted from #36656 per maintainer request — each in-tree fix from that PR as an isolated change.