Preserve inline CSF3 story parameters in full-source preset - #36661
Open
Dmytro Kirpa (dmytrokirpa) with Copilot wants to merge 4 commits into
Open
Preserve inline CSF3 story parameters in full-source preset#36661Dmytro Kirpa (dmytrokirpa) with Copilot wants to merge 4 commits into
Dmytro Kirpa (dmytrokirpa) with Copilot wants to merge 4 commits into
Conversation
Co-authored-by: dmytrokirpa <1492102+dmytrokirpa@users.noreply.github.com>
Co-authored-by: dmytrokirpa <1492102+dmytrokirpa@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix babel-preset-storybook-full-source overwriting CSF3 parameters
Aug 31, 2026
Dmytro Kirpa (dmytrokirpa)
left a comment
Contributor
There was a problem hiding this comment.
Copilot fix review comments
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "type": "patch", | |||
| "comment": "Preserve inline CSF3 story parameters when adding fullSource", | |||
Contributor
There was a problem hiding this comment.
Suggested change
| "comment": "Preserve inline CSF3 story parameters when adding fullSource", | |
| "comment": "fix: Preserve inline CSF3 story parameters when adding fullSource", |
| export default meta; | ||
| type Story = StoryObj<typeof meta>; | ||
|
|
||
| export const Default: Story = { |
Contributor
There was a problem hiding this comment.
lets also add a test for StoryFn with parameters if we don't have such yet:
type Story = StoryFn<typeof meta>;
export const Default: Story = () => <div>Example</div>;
Default.parameters = {
docs: { story: { docs: { description: { story: 'Description' } } }
}
Co-authored-by: dmytrokirpa <1492102+dmytrokirpa@users.noreply.github.com>
Contributor
Author
Addressed in |
Dmytro Kirpa (dmytrokirpa)
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
babel-preset-storybook-full-sourcetreated CSF3 stories with inlineparametersas missing parameters, then appendedStory.parameters = {}before assigningfullSource. This dropped existing Storybook metadata such asdocs.description.story.Parameter detection
parameterson CSF3 object story exports.asandsatisfies.Regression coverage
Meta/StoryObjpattern.