Don’t auto-import undefined - #35504
Merged
Andrew Branch (andrewbranch) merged 1 commit intoDec 5, 2019
Merged
Conversation
Andrew Branch (andrewbranch)
requested review from
Orta Therox (orta) and
Sheetal Nandi (sheetalkamat)
December 4, 2019 19:59
Sheetal Nandi (sheetalkamat)
approved these changes
Dec 5, 2019
Orta Therox (orta)
approved these changes
Dec 5, 2019
Member
|
Also fixes #35036, as far as I can tell, since repros have stopped coming in. |
This was referenced Mar 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35458
An external module that exports
undefinedcaused some code added in #32517 to crash. It turns out I was unable to actually reproduce that exact crash in a failing test because the test harness throws immediately upon discovering multiple completions forundefined, which is pretty fair, so Inow filter
undefinedfrom being considered as an auto-import altogether.