Fix type annotations originating in property initializers being emitted in constructor - #31805
Closed
Andrew Branch (andrewbranch) wants to merge 2 commits into
Closed
Fix type annotations originating in property initializers being emitted in constructor#31805Andrew Branch (andrewbranch) wants to merge 2 commits into
Andrew Branch (andrewbranch) wants to merge 2 commits into
Conversation
Andrew Branch (andrewbranch)
requested review from
Anders Hejlsberg (ahejlsberg) and
Ron Buckton (rbuckton)
June 6, 2019 22:13
Ron Buckton (rbuckton)
approved these changes
Jun 6, 2019
Ron Buckton (rbuckton)
left a comment
Ron Buckton (rbuckton)
left a comment
Contributor
There was a problem hiding this comment.
Yeah, this is exactly the same thing I saw as well.
|
|
||
| const parameters = transformConstructorParameters(constructor); | ||
| const body = transformConstructorBody(node.members, constructor, parametersWithPropertyAssignments); | ||
| const body = transformConstructorBody(existingMembers, constructor, parametersWithPropertyAssignments); |
Member
Author
There was a problem hiding this comment.
TL;DR: node.members are the original, untransformed members; existingMembers have been transformed through visitTypeScript.
Member
|
TypeScript Bot (@typescript-bot) test this |
Contributor
|
Heya Anders Hejlsberg (@ahejlsberg), I've started to run the extended test suite on this PR at e203073. You can monitor the build here. It should now contribute to this PR's status checks. |
Contributor
Member
Author
|
Closing as #30467 was reverted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31792