Skip to content

Extension loading and management tools - #10159

Closed
Wesley Wigham (weswigham) wants to merge 3 commits into
masterfrom
extension-loading
Closed

Extension loading and management tools#10159
Wesley Wigham (weswigham) wants to merge 3 commits into
masterfrom
extension-loading

Conversation

@weswigham

Copy link
Copy Markdown
Member

From #9038, this PR contains just the framework for specifying, loading, testing, and otherwise managing compiler extensions.

Most of this PR (in terms of lines of code) is just a test harness for compiling, running, and verifying extensions.

Anders Hejlsberg (@ahejlsberg) Vladimir Matveev (@vladima) Ron Buckton (@rbuckton) Mohamed Hegazy (@mhegazy) We can vet and merge this framework, and then proceed to expose extensibility points as they are ready.

Comment thread src/compiler/core.ts


namespace ts {
export function startsWith(str: string, prefix: string): boolean {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: is this intentional to not mark "internal"?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aye. It was a useful tool which I was using in my tests. I could just copy
it, I suppose, if having them public is an issue.

On Thu, Aug 11, 2016, 2:40 PM Yui notifications@github.com wrote:

In src/compiler/core.ts
#10159 (comment):

@@ -2,6 +2,17 @@
///

+namespace ts {

  • export function startsWith(str: string, prefix: string): boolean {

question: is this intentional to not mark "internal"?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/TypeScript/pull/10159/files/5ad76bd5fdd630ddc580ac497fc98d44f9acd4d1#r74508706,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACzAMigcs3CcrH9FBPolH9QTfGOZ7QNbks5qe5bPgaJpZM4JdPPR
.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it will be an issue. I was just curious :)

"code": 6136
},
"No types specified in 'package.json' but 'allowJs' is set, so returning 'main' value of '{0}'": {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra space?

@mhegazy

Copy link
Copy Markdown
Contributor
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants