Allow method return types to end with a digit - #199
Closed
Marin Marinov (gcnew) wants to merge 2 commits into
Closed
Allow method return types to end with a digit#199Marin Marinov (gcnew) wants to merge 2 commits into
Marin Marinov (gcnew) wants to merge 2 commits into
Conversation
|
Hi Marin Marinov (@gcnew), I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
Marin Marinov (gcnew)
force-pushed
the
master
branch
from
June 30, 2016 15:44
6d2b601 to
7d36891
Compare
|
Marin Marinov (@gcnew), Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
| ^^public ^^testMethodReturnType12(): number | string [] { ^^return } | ||
| ^^public ^^testMethodReturnType13(): [number, number] | string [] { ^^return [""] } | ||
| } No newline at end of file | ||
| ^^public ^^testMethodReturnType14(): EndsWithDigit1 { ^^return 123 } |
Contributor
There was a problem hiding this comment.
Can you add a check to scope of 123 and after 123, like --
^^return ^^123 ^^} 
Contributor
|
Sorry for the delay, this should be fixed now by #257 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syntax coloring fails if method return type ends with a digit. This pull request allows digits to be the last character in
type-annotation.endregular expression.Fixes microsoft/TypeScript#9444 and should be in line with the to-be-added numeric literal types microsoft/TypeScript#9407.