Various fixes and improvements. - #22
Merged
Merged
Conversation
nulltoken
commented
May 5, 2011
nulltoken
commented
Member
- Port some tests from cgit and fix implementation to make them pass
- Add tests covering the creation of tags
- Add some (currently failing and ignored) tests related to reference renaming
- Fix minor issues pinpointed by Code Analysis
- Add Repository.ApplyTag() extension method(s)
… existing reference
Member
There was a problem hiding this comment.
Not a big deal, but I wouldn't mind collapsing these kinds of tests into a single CreateRepoWithBadParamsThrows() just to make things easier to read and maintain.
Member
Author
There was a problem hiding this comment.
You're right. I'll take care of this.
Member
|
Looks good Em! |
…ings easier to read and maintain Credit goes to @tclem for raising this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.