Skip to content

Numbers - #62

Merged
tarasyyyk merged 6 commits into
javascript-tutorial:masterfrom
alexandrtovmach:translation/js-dataTypes-number
Mar 6, 2020
Merged

Numbers#62
tarasyyyk merged 6 commits into
javascript-tutorial:masterfrom
alexandrtovmach:translation/js-dataTypes-number

Conversation

@alexandrtovmach

Copy link
Copy Markdown
Contributor

No description provided.

@CLAassistant

CLAassistant commented Mar 5, 2020

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@tarasyyyk tarasyyyk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very correct translation! No typos at all.

Comment thread 1-js/05-data-types/02-number/article.md Outdated
Comment thread 1-js/05-data-types/02-number/article.md Outdated
Co-Authored-By: Taras <oster.ok@gmail.com>
Comment thread 1-js/05-data-types/02-number/article.md Outdated

@alexgalkin alexgalkin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Чудовий початок!

@alexandrtovmach
alexandrtovmach marked this pull request as ready for review March 6, 2020 10:41
@alexandrtovmach

Copy link
Copy Markdown
Contributor Author

@tarasyyyk @alexgalkin
переклад завершено, можна ревьювити та мерджити

@tarasyyyk tarasyyyk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Впринципі, немає помилок в перекладі. Можна мерджити, але є деякі зауваження.
@alexgalkin гляньте «незамилиним» оком на мої виправлення, чи згідні ви з ними.

Comment thread 1-js/05-data-types/02-number/1-sum-interface/solution.md Outdated
Comment thread 1-js/05-data-types/02-number/2-why-rounded-down/solution.md
Comment thread 1-js/05-data-types/02-number/2-why-rounded-down/solution.md Outdated
Comment thread 1-js/05-data-types/02-number/article.md Outdated
@javascript-translate-bot

Copy link
Copy Markdown
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Co-Authored-By: Taras <oster.ok@gmail.com>
@alexandrtovmach

Copy link
Copy Markdown
Contributor Author

/done

@tarasyyyk
tarasyyyk merged commit 796b2b4 into javascript-tutorial:master Mar 6, 2020
@alexandrtovmach
alexandrtovmach deleted the translation/js-dataTypes-number branch March 6, 2020 20:45
@tarasyyyk

Copy link
Copy Markdown
Collaborator

Thanks for your contribution! @all-contributors please add @alexandrtovmach to list for translation.

@allcontributors

Copy link
Copy Markdown
Contributor

@tarasyyyk

I've put up a pull request to add @alexandrtovmach! 🎉

@alexgalkin

Copy link
Copy Markdown
Contributor

@alexandrtovmach amazing example of translation. Thanks for your contribution!

@tarasyyyk tarasyyyk removed the needs +1 label Mar 6, 2020
@tarasyyyk tarasyyyk changed the title Translation for js-dataTypes-number Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants