Capturing groups - #441
Merged
dolgachio merged 2 commits intoMar 25, 2023
Merged
Conversation
dolgachio
requested changes
Mar 25, 2023
dolgachio
left a comment
dolgachio
left a comment
Collaborator
There was a problem hiding this comment.
Дякую за переклад і ваш внесок! Я додав кілька коментарів до тексту, з вашого боку нічого більше не треба, я сам внесу необхідні зміни
|
|
||
| ```js run | ||
| let str = "Gogogo John!"; | ||
| let str = "Gogogo Іван!"; |
Collaborator
There was a problem hiding this comment.
Suggested change
| let str = "Gogogo Іван!"; | |
| let str = "Gogogo John!"; |
| alert( result[0] ); // Gogogo John (full match) | ||
| alert( result[1] ); // John | ||
| alert( result.length ); // 2 (no more items in the array) | ||
| alert( result[0] ); // Gogogo Іван (повний збіг) |
Collaborator
There was a problem hiding this comment.
Suggested change
| alert( result[0] ); // Gogogo Іван (повний збіг) | |
| alert( result[0] ); // Gogogo John (повний збіг) |
| alert( result[1] ); // John | ||
| alert( result.length ); // 2 (no more items in the array) | ||
| alert( result[0] ); // Gogogo Іван (повний збіг) | ||
| alert( result[1] ); // Іван |
Collaborator
There was a problem hiding this comment.
Suggested change
| alert( result[1] ); // Іван | |
| alert( result[1] ); // John |
| alert( result.length ); // 2 (no more items in the array) | ||
| alert( result[0] ); // Gogogo Іван (повний збіг) | ||
| alert( result[1] ); // Іван | ||
| alert( result.length ); // 2 (інших елементів у масиві нема) |
Collaborator
There was a problem hiding this comment.
Suggested change
| alert( result.length ); // 2 (інших елементів у масиві нема) | |
| alert( result.length ); // 2 (інших елементів у масиві немає) |
|
|
||
| - The method `str.match` returns capturing groups only without flag `pattern:g`. | ||
| - The method `str.matchAll` always returns capturing groups. | ||
| - Метод `str.match` повертає групи захоплення лише без прапору `pattern:g`. |
Collaborator
There was a problem hiding this comment.
Suggested change
| - Метод `str.match` повертає групи захоплення лише без прапору `pattern:g`. | |
| - Метод `str.match` повертає групи захоплення лише без прапорцю `pattern:g`. |
Contributor
|
Please make the requested changes. After it, add a comment "/done". |
dolgachio
approved these changes
Mar 25, 2023
Collaborator
|
@all-contributors add @SamGreenberg for translation |
Contributor
|
@stas-dolgachov @SamGreenberg already contributed before to translation |
Contributor
|
Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.