Skip to content

contacts.show_contact_by_external_id raises ApiError instead of NotFoundError on 404 #292

Description

@pymen

The show_contact_by_external_id method in the Python SDK raises a generic ApiError for 404 responses instead of the expected NotFoundError.

This is inconsistent with other methods in the same SDK - for example, companies.attach_contact and companies.detach_contact both correctly raise NotFoundError on 404.

ForbiddenError, is probably also affected

see intercom/contacts/raw_client.py -> show_contact_by_external_id i.e. ~1072 line

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions