Skip to content

Remove the hash validation and remove them from the payload on save - #619

Merged
VedranZoricic merged 3 commits into
masterfrom
vedran/ignore_custom_objects_on_save_and_allow_on_read
Sep 1, 2025
Merged

Remove the hash validation and remove them from the payload on save#619
VedranZoricic merged 3 commits into
masterfrom
vedran/ignore_custom_objects_on_save_and_allow_on_read

Conversation

@VedranZoricic

@VedranZoricic VedranZoricic commented Sep 1, 2025

Copy link
Copy Markdown
Contributor

Context

Why

  • When saving the Intercom contact here we try to parse the response from the server back here. If the contact contains a Custom Object it will throw a ArgumentError here because the CustomObject is a hash.

FIx

  • Allow hashes when validating
  • Remove hashes when saving ( ignore them in to_submittable_hash)
@VedranZoricic VedranZoricic self-assigned this Sep 1, 2025
@VedranZoricic
VedranZoricic force-pushed the vedran/ignore_custom_objects_on_save_and_allow_on_read branch 2 times, most recently from 04fb9d4 to 87b537c Compare September 1, 2025 12:27
@VedranZoricic
VedranZoricic force-pushed the vedran/ignore_custom_objects_on_save_and_allow_on_read branch from 794441a to 87b537c Compare September 1, 2025 12:51
@VedranZoricic
VedranZoricic force-pushed the vedran/ignore_custom_objects_on_save_and_allow_on_read branch from 87b537c to e17f0e9 Compare September 1, 2025 13:12
@dan0505
dan0505 requested a review from a team September 1, 2025 13:20
@VedranZoricic
VedranZoricic merged commit 0d3e6a9 into master Sep 1, 2025
5 checks passed
@VedranZoricic
VedranZoricic deleted the vedran/ignore_custom_objects_on_save_and_allow_on_read branch September 1, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants