Skip to content

[feature] Conversation : Add/remove nested resource 'contact' - #517

Merged
murtron merged 3 commits into
intercom:masterfrom
WaKeMaTTa:conversation-add-remove-nested-contact
Mar 10, 2020
Merged

[feature] Conversation : Add/remove nested resource 'contact'#517
murtron merged 3 commits into
intercom:masterfrom
WaKeMaTTa:conversation-add-remove-nested-contact

Conversation

@WaKeMaTTa

@WaKeMaTTa WaKeMaTTa commented Mar 6, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Implemented add_contact and remove_contact actions in Conversation.

# Add a contact to a conversation
conversation.add_contact(admin_id: admin.id, customer: { intercom_user_id: contact.id })

# Remove a contact from a conversation
conversation.remove_tag(id: contact.id, admin_id: admin.id)

Fixes #515
@WaKeMaTTa
WaKeMaTTa marked this pull request as ready for review March 6, 2020 17:22
@WaKeMaTTa
WaKeMaTTa force-pushed the conversation-add-remove-nested-contact branch from 792367b to 066ddc7 Compare March 6, 2020 17:22
@WaKeMaTTa
WaKeMaTTa force-pushed the conversation-add-remove-nested-contact branch from 066ddc7 to 3035aa7 Compare March 6, 2020 17:23
murtron
murtron reviewed Mar 9, 2020
View reviewed changes
Comment thread README.md Outdated
@murtron

murtron commented Mar 9, 2020

Copy link
Copy Markdown
Contributor

Nice one @WaKeMaTTa, this is great! Just one minor README change and I'll include this in the next release.
@WaKeMaTTa @murtron
[typo] README - Fix typo
0be174a 
Co-Authored-By: Matthew Murray <matthew.murray@intercom.io>
@WaKeMaTTa
WaKeMaTTa requested a review from murtron March 9, 2020 12:04
@murtron
murtron merged commit dffd960 into intercom:master Mar 10, 2020
@murtron murtron mentioned this pull request Mar 10, 2020
Merged
@WaKeMaTTa
WaKeMaTTa deleted the conversation-add-remove-nested-contact branch March 10, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@WaKeMaTTa @murtron