Skip to content

Accept 'Unstable' API Version - #505

Merged
jonnyom merged 1 commit into
masterfrom
ga/add-support-for-unstable-version
Nov 14, 2019
Merged

Accept 'Unstable' API Version#505
jonnyom merged 1 commit into
masterfrom
ga/add-support-for-unstable-version

Conversation

@GabrielAnca

@GabrielAnca GabrielAnca commented Nov 13, 2019

Copy link
Copy Markdown
Contributor

Why?

When trying to use the Unstable version, it fails validation, even though it is a valid API version. See docs.

ArgumentError: Malformed version number string Unstable

How?

Accept Unstable as a valid API version.

@jonnyom jonnyom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Shall merge in the morning.

@jonnyom
jonnyom merged commit 91378c1 into master Nov 14, 2019
@jonnyom
jonnyom deleted the ga/add-support-for-unstable-version branch November 14, 2019 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants