Skip to content

feat(grpc): hard-cut to v1 grpc interface - #80

Merged
markovejnovic merged 14 commits into
mainfrom
marko/hyp-7-stabilize-grpc
Jul 12, 2026
Merged

feat(grpc): hard-cut to v1 grpc interface#80
markovejnovic merged 14 commits into
mainfrom
marko/hyp-7-stabilize-grpc

Conversation

@markovejnovic

@markovejnovic markovejnovic commented Jul 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No description provided.

@markovejnovic
feat(grpc): replace google.protobuf.Empty with dedicated messages
4dac0f0 
StopVm now returns StopVmResponse; ListVms takes ListVmsRequest. Empty
can never grow a field; purpose-built messages keep both RPCs extensible.
@markovejnovic
feat(grpc): UNSPECIFIED enum zero-values, reject unset
93a56f8 
InstanceType/Architecture gain a *_UNSPECIFIED = 0 sentinel; real values
shift up one. An omitted instance_type/arch is now INVALID_ARGUMENT rather
than a silent MICRO/x86_64 default (AIP-126).
@markovejnovic
feat(grpc): keyset pagination for ListVms (AIP-158)
89d4d3f 
page_size/page_token on the request, next_page_token on the response. A pure
Hyper.Grpc.Page core cursors by vm_id over Cluster.Routing.all/0; the keyset
cursor is robust to the registry changing mid-listing.
@markovejnovic
feat(grpc)!: promote public contract hyper.grpc.v0 -> v1
b5e2af9 
Freeze the cleaned-up contract as the first stable version. Service address
is now hyper.grpc.v1.Hyper; generated bindings move to Hyper.Grpc.V1.*.

BREAKING CHANGE: clients must target the hyper.grpc.v1 package.
@markovejnovic
docs: gRPC guide for v1 (stable contract, no Empty, pagination)
763fb71 
Swap v0->v1 throughout, replace the google.protobuf.Empty examples with the
dedicated ListVms/StopVm messages, document required enum fields and the
paged ListVms flow, and the v2-side-by-side stability policy.
@markovejnovic
chore(grpc): final-review polish (changelog, page property, style, docs)
38309d4
@codecov

codecov Bot commented Jul 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
lib/hyper/grpc/page.ex 93.33% 1 Missing ⚠️
lib/hyper/grpc/server.ex 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!
@github-actions

github-actions Bot commented Jul 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Test Results

    4 files  ± 0  225 suites  +4   4m 21s ⏱️ + 2m 0s
  649 tests +12  649 ✅ +12    0 💤 ± 0  0 ❌ ±0 
1 099 runs  +24  649 ✅ +12  450 💤 +12  0 ❌ ±0 

Results for commit ae94c92. ± Comparison against base commit c5f3b70.

♻️ This comment has been updated with latest results.
@markovejnovic
markovejnovic marked this pull request as ready for review July 12, 2026 05:11
@markovejnovic markovejnovic changed the title feat(grpc)!: promote public contract hyper.grpc.v0 → v1 (remove Empty, forward-compat, pagination) Jul 12, 2026
@markovejnovic
markovejnovic merged commit 155b7f9 into main Jul 12, 2026
8 checks passed
@markovejnovic
markovejnovic deleted the marko/hyp-7-stabilize-grpc branch July 12, 2026 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@markovejnovic