docs: First draft of Helm GCP guide - #17503
Merged
Merged
Conversation
Contributor
|
💻 Deploy preview deleted. |
JStickler
reviewed
May 22, 2025
JStickler
left a comment
Contributor
There was a problem hiding this comment.
[docs team] Sorry this took me so long.
Co-authored-by: J Stickler <julie.stickler@grafana.com> Signed-off-by: nicolevanderhoeven <36070553+nicolevanderhoeven@users.noreply.github.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com> Signed-off-by: nicolevanderhoeven <36070553+nicolevanderhoeven@users.noreply.github.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com> Signed-off-by: nicolevanderhoeven <36070553+nicolevanderhoeven@users.noreply.github.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com> Signed-off-by: nicolevanderhoeven <36070553+nicolevanderhoeven@users.noreply.github.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com> Signed-off-by: nicolevanderhoeven <36070553+nicolevanderhoeven@users.noreply.github.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com> Signed-off-by: nicolevanderhoeven <36070553+nicolevanderhoeven@users.noreply.github.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com> Signed-off-by: nicolevanderhoeven <36070553+nicolevanderhoeven@users.noreply.github.com>
Jayclifford345
requested changes
May 23, 2025
Jayclifford345
left a comment
Contributor
There was a problem hiding this comment.
Hey @nicolevanderhoeven, awsome work. I have added some changes and comments after testing but once we get those in I think we are good to go!
Co-authored-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com> Signed-off-by: nicolevanderhoeven <36070553+nicolevanderhoeven@users.noreply.github.com>
Co-authored-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com> Signed-off-by: nicolevanderhoeven <36070553+nicolevanderhoeven@users.noreply.github.com>
Co-authored-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com> Signed-off-by: nicolevanderhoeven <36070553+nicolevanderhoeven@users.noreply.github.com>
Co-authored-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com> Signed-off-by: nicolevanderhoeven <36070553+nicolevanderhoeven@users.noreply.github.com>
Co-authored-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com> Signed-off-by: nicolevanderhoeven <36070553+nicolevanderhoeven@users.noreply.github.com>
… KSA name with placeholder
Jayclifford345
approved these changes
Jun 6, 2025
JStickler
reviewed
Jun 9, 2025
JStickler
left a comment
Contributor
There was a problem hiding this comment.
[docs team] Just a few more small tweaks, but LGTM. I think we can get this merged tomorrow.
Co-authored-by: J Stickler <julie.stickler@grafana.com> Signed-off-by: nicolevanderhoeven <36070553+nicolevanderhoeven@users.noreply.github.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com> Signed-off-by: nicolevanderhoeven <36070553+nicolevanderhoeven@users.noreply.github.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com> Signed-off-by: nicolevanderhoeven <36070553+nicolevanderhoeven@users.noreply.github.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com> Signed-off-by: nicolevanderhoeven <36070553+nicolevanderhoeven@users.noreply.github.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com> Signed-off-by: nicolevanderhoeven <36070553+nicolevanderhoeven@users.noreply.github.com>
loki-gh-app Bot
pushed a commit
that referenced
this pull request
Jun 10, 2025
Signed-off-by: nicolevanderhoeven <36070553+nicolevanderhoeven@users.noreply.github.com> Co-authored-by: J Stickler <julie.stickler@grafana.com> Co-authored-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com> (cherry picked from commit 92b0ff4)
loki-gh-app Bot
pushed a commit
that referenced
this pull request
Jun 10, 2025
Signed-off-by: nicolevanderhoeven <36070553+nicolevanderhoeven@users.noreply.github.com> Co-authored-by: J Stickler <julie.stickler@grafana.com> Co-authored-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com> (cherry picked from commit 92b0ff4)
felix0102
pushed a commit
to felix0102/loki
that referenced
this pull request
Aug 2, 2026
Signed-off-by: nicolevanderhoeven <36070553+nicolevanderhoeven@users.noreply.github.com> Co-authored-by: J Stickler <julie.stickler@grafana.com> Co-authored-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added instructions and the Helm config for deploying Loki on GCP.