feat: add tests for enforcing limits in distributors - #17124
Merged
Conversation
grobinson-grafana
force-pushed
the
grobinson/add-tests-for-enforcing-limits
branch
5 times, most recently
from
April 11, 2025 11:43
57643ab to
8b36619
Compare
6 tasks
grobinson-grafana
marked this pull request as draft
April 11, 2025 14:41
periklis
reviewed
Apr 11, 2025
grobinson-grafana
force-pushed
the
grobinson/add-tests-for-enforcing-limits
branch
from
April 14, 2025 10:41
edab635 to
23239d8
Compare
grobinson-grafana
force-pushed
the
grobinson/add-tests-for-enforcing-limits
branch
from
April 14, 2025 13:20
23239d8 to
4a993f3
Compare
grobinson-grafana
marked this pull request as ready for review
April 14, 2025 13:20
periklis
approved these changes
Apr 14, 2025
grobinson-grafana
added a commit
that referenced
this pull request
Apr 15, 2025
grobinson-grafana
added a commit
that referenced
this pull request
Apr 15, 2025
chaudum
pushed a commit
that referenced
this pull request
Apr 15, 2025
Contains backports of these commits: ``` 2cde9b1 fix: skip streams over limits in dry-run mode (#17114) 805125c fix: fix a bug where limits were incorrect after #16937 (#17224) d106042 fix: fix bug where expectedStreamUsageRequest was not used (#17223) 69aeda1 feat: add tests for enforcing limits in distributors (#17124) ```
This was referenced Jun 24, 2025
This was referenced Jul 7, 2025
This was referenced Jul 21, 2025
felix0102
pushed a commit
to felix0102/loki
that referenced
this pull request
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This pull request adds missing tests for
distributor.Pushto make sure requests are rejected as expected when limits are exceeded.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR