[loki] Set FOLDER_ANNOTATION in Distributed & SingleBinary modes - #176
Merged
Conversation
…eployments Signed-off-by: Vincent Rivellino <github@vince-riv.io>
vrivellino
requested review from
QuentinBisson,
TheRealNoob and
jkroepke
as code owners
March 18, 2026 01:14
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
grafana/loki#13289 added a chart value (
sidecar.rules.folderAnnotation) that setsFOLDER_ANNOTATIONon the rules sidecar. However, it only set that environment variable on loki-backend in SimpleScalable mode.This PR sets
FOLDER_ANNOTATIONeven in SIngleBinary and Distributed deployment modesWhich issue this PR fixes
N/A
Special notes for your reviewer
Checklist
[grafana])