This repository was archived by the owner on Jun 8, 2026. It is now read-only.
fix: Issue#1154 Improper initialisation of JsonObject when called on JsonObject of list - #1166
Merged
Merged
Conversation
product-auto-label
Bot
added
the
api: spanner
harshachinta
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
harshachinta
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
harshachinta
approved these changes
Aug 27, 2024
harshachinta
enabled auto-merge (squash)
August 27, 2024 13:17
harshachinta
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes improper initialisation of JsonObject when called on JsonObject of list:
Currently,
_is_arrayflag is lost when JsonObject is called again on a JsonObject which is represented with an array.ex:
JsonObject(JsonObject( [{"foo": "bar1"}, {"foo": "bar2"}] ))Fixes #1154 🦕