Skip to content

Add matching END tags - #7529

Merged
crwilcox merged 1 commit into
googleapis:masterfrom
sethtroisi:unmatched
Mar 18, 2019
Merged

Add matching END tags#7529
crwilcox merged 1 commit into
googleapis:masterfrom
sethtroisi:unmatched

Conversation

@sethtroisi

@sethtroisi sethtroisi commented Mar 18, 2019

Copy link
Copy Markdown
Contributor

Unmatched tag are at line 780/781.

It would be nice to know why this worked (so that I can be sure this fix is doing something meanful) or if I can just remove the start tags which are otherwise unused

@sethtroisi
sethtroisi requested a review from crwilcox as a code owner March 18, 2019 18:09
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 18, 2019
@crwilcox

Copy link
Copy Markdown
Contributor

Hi @sethtroisi , the tags are used for tracking this test in our code. The missing END tags means we wouldn't know the region, but we don't strictly need that information. Typically, these define regions of code to be used as samples but the spanner_test_* labels are just used to track existence.

@crwilcox
crwilcox merged commit 484c63a into googleapis:master Mar 18, 2019
@sethtroisi
sethtroisi deleted the unmatched branch March 18, 2019 18:47
@sethtroisi

Copy link
Copy Markdown
Contributor Author

Wow this is crazy, that appears to be the only unmatched tag

grep -hri '^\s*# \[\(END\|START\)' | sed -e 's/\s*# \[//' -e 's/]$//' | awk '{print $2, $1}' | LC_COLLATE=C sort | uniq -c | paste -d" " - - | awk '{print $1, $4, $6, $3, $2, $5}' | awk '$1 != $2 {print $0}'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

3 participants