Skip to content

Spanner: pick up fixes to GAPIC generator. - #6576

Merged
tseaver merged 2 commits into
googleapis:masterfrom
tseaver:6507-spanner-manual_synth
Nov 19, 2018
Merged

Spanner: pick up fixes to GAPIC generator.#6576
tseaver merged 2 commits into
googleapis:masterfrom
tseaver:6507-spanner-manual_synth

Conversation

@tseaver

@tseaver tseaver commented Nov 19, 2018

Copy link
Copy Markdown
Contributor
@tseaver
Spanner: pick up fixes to GAPIC generator.
e515ff7 
Includes fixes from these PRs:

- googleapis/gapic-generator#2407 (closing googleapis/gapic-generator#2389)
- googleapis/gapic-generator#2396 (for #5523 and dupes).

Includes changes to *all* generated tests.

Removes now-spurious docstring fixups.

Closes #6507.
@tseaver tseaver added api: spanner Issues related to the Spanner API. codegen labels Nov 19, 2018
@tseaver
tseaver requested a review from crwilcox November 19, 2018 16:42
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2018
@tseaver tseaver mentioned this pull request Nov 19, 2018
Closed
@tseaver
tseaver merged commit a7ce1ff into googleapis:master Nov 19, 2018
@tseaver
tseaver deleted the 6507-spanner-manual_synth branch November 19, 2018 17:56
parthea pushed a commit that referenced this pull request Mar 9, 2026
@tseaver
Spanner: pick up fixes to GAPIC generator. (#6576)
40ce9b0 
Includes fixes from these PRs:

- googleapis/gapic-generator#2407 (closing googleapis/gapic-generator#2389)
- googleapis/gapic-generator#2396 (for #5523 and dupes).

Includes changes to *all* generated tests.

Removes now-spurious docstring fixups.

Closes #6507.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement. codegen

2 participants

@tseaver @googlebot