Skip to content

Pin 'Getting started with gcloud' section on every page. - #554

Closed
tseaver wants to merge 1 commit into
googleapis:masterfrom
tseaver:553-pin_getting_started_on_every_page
Closed

Pin 'Getting started with gcloud' section on every page.#554
tseaver wants to merge 1 commit into
googleapis:masterfrom
tseaver:553-pin_getting_started_on_every_page

Conversation

@tseaver

@tseaver tseaver commented Jan 15, 2015

Copy link
Copy Markdown
Contributor

Make it togglable, like the node docs.

Fixes #553.

Make it togglable, like the node docs.

Fixes #553.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 15, 2015
@tseaver

tseaver commented Jan 15, 2015

Copy link
Copy Markdown
Contributor Author

To review, run tox -e docs and then open docs/_build/html/index.html.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same when pulling 7da6282 on tseaver:553-pin_getting_started_on_every_page into 55285f9 on GoogleCloudPlatform:master.

@dhermes

dhermes commented Jan 15, 2015

Copy link
Copy Markdown
Contributor

@silvolu Just had a remark about this. I'll leave the review to him.

@silvolu

silvolu commented Jan 15, 2015

Copy link
Copy Markdown
Contributor

I think @jgeewax should review; I was just commenting on the historical reason why there is no pinning :)

@dhermes dhermes changed the title Pin 'Getting stared with gcloud' section on every page. Jan 22, 2015
@dhermes

dhermes commented Mar 2, 2015

Copy link
Copy Markdown
Contributor

This is very much in limbo.

Do we need this and is #553 actually necessary?

/cc @jgeewax

@dhermes

dhermes commented Mar 31, 2015

Copy link
Copy Markdown
Contributor

Since this has languished for 2.5 months, I'm closing out. If we decided #533 is relevant, we can revisit.

@dhermes dhermes closed this Mar 31, 2015
@tseaver
tseaver deleted the 553-pin_getting_started_on_every_page branch May 1, 2015 14:19
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
fix(deps): require proto-plus >= 1.22.0
parthea pushed a commit that referenced this pull request Sep 22, 2023
Source-Link: https://togithub.com/googleapis/synthtool/commit/352b9d4c068ce7c05908172af128b294073bf53c
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3e3800bb100af5d7f9e810d48212b37812c1856d20ffeafb99ebe66461b61fc7
parthea pushed a commit that referenced this pull request Oct 21, 2023
Source-Link: https://togithub.com/googleapis/synthtool/commit/5f2a6089f73abf06238fe4310f6a14d6f6d1eed3
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8555f0e37e6261408f792bfd6635102d2da5ad73f8f09bcb24f25e6afb5fac97
parthea pushed a commit that referenced this pull request Aug 21, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 16, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 22, 2025
* fix: Prevent sending full table scan when retrying

Update the retry logic. Don't send empty row_key and empty row_ranges
if the original message didn't ask for those.

Closes internal issue 214449800

* Create InvalidRetryRequest exception.
Raise InvalidRetryRequest instead of StopIteration
Catch the InvalidRetryRequest
Handle stop the retry request if row_limit has been reached.

* Improve test coverage

* Improve test coverage
parthea pushed a commit that referenced this pull request Nov 24, 2025
* chore: updated CHANGELOG.md [ci skip]

* chore: updated setup.py

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Nov 24, 2025
* add types to grpc call wrappers

* fixed tests

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* changed type

* changed async types

* added tests

* fixed lint issues

* Update tests/asyncio/test_grpc_helpers_async.py

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* turned GrpcStream into a type alias

* added test for GrpcStream

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* added comment

* reordered types

* changed type var to P

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
* chore: update mypy package target

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
Source-Link: googleapis/synthtool@7ff4aad
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:462782b0b492346b2d9099aaff52206dd30bc8e031ea97082e6facecc2373244
parthea pushed a commit that referenced this pull request Nov 24, 2025
* fix: Change button to .png file

* Change the "Guide Me" button to a .png file to work with RST `image`
* Avoids `raw` directive disabled by PyPi
* Fixes #553

* Fix unexpected unindent in docs

Add copy of png file to render correctly in GitHub
readme and Sphinx generated docs.
parthea pushed a commit that referenced this pull request Nov 24, 2025
* Add .python-version to .gitignore

* Add initial class/test for instrumentation_source

* Add version and truncate logic

* Add instrumentation tests and severity info

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Add method to update and validate existing info

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Add .python-version to gitignore

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Implement hook to add instrumentation for logger

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Add tests for logger instrumentation logic

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update structured log handler to emit info

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Refactor structured log and add unit test

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Add side effect to unit test

* Ensure that instrumentation info is only called once

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update to environment submodule

* Fix linter errors

* chore(main): release 3.1.0 (#479)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* docs: Change button in README to .png file (#554)

* fix: Change button to .png file

* Change the "Guide Me" button to a .png file to work with RST `image`
* Avoids `raw` directive disabled by PyPi
* Fixes #553

* Fix unexpected unindent in docs

Add copy of png file to render correctly in GitHub
readme and Sphinx generated docs.

* chore(main): release 3.1.1 (#557)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* Update env-tests submodule

* Minor format update

* Fix system test to skip diagnostic log entry

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update truncation logic based on feedback

* Update environment tests

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Fix broken unit test

* Fix broken unit test

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Change default name/version

* Refactor add_instrumentation

Return a new list instead of a mutated original
Do not return after first log without info

* Add more documentation to validation methods

* Refactor add_instrumentation to be more pythonic

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update environemnt tests

* Refactor _is_valid and add test

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Add more detail to method documentation

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Move methods to private

* Change instumentation_added to private

* Fix some issues with validation method

Add a test

* Fix bug in _add_instrumentation

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Simplify string truncation

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Remove unused import to fix lint

* Remove validate_and_update_instrumentation

Simplify code by adding a single instrumentation entry
instead of validating potential existing entries

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Remove _is_valid code (no longer checked)

* Run nox blacken

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Remove extraneous unit test

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Daniel Sanche <d.sanche14@gmail.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
…ync (#554)

* fix: `@non_transactional` decorator was not working correctly with async

Fixes #552

* We don't really need `_get_transaction` at all.

In all cases, we know where to get the transaction from.
parthea pushed a commit that referenced this pull request Nov 25, 2025
* fix: Change button to .png file

* Change the "Guide Me" button to a .png file to work with RST `image`
* Avoids `raw` directive disabled by PyPi
* Fixes #553

* Fix unexpected unindent in docs

Add copy of png file to render correctly in GitHub
readme and Sphinx generated docs.
parthea pushed a commit that referenced this pull request Nov 25, 2025
* Add .python-version to .gitignore

* Add initial class/test for instrumentation_source

* Add version and truncate logic

* Add instrumentation tests and severity info

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Add method to update and validate existing info

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Add .python-version to gitignore

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Implement hook to add instrumentation for logger

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Add tests for logger instrumentation logic

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update structured log handler to emit info

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Refactor structured log and add unit test

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Add side effect to unit test

* Ensure that instrumentation info is only called once

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update to environment submodule

* Fix linter errors

* chore(main): release 3.1.0 (#479)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* docs: Change button in README to .png file (#554)

* fix: Change button to .png file

* Change the "Guide Me" button to a .png file to work with RST `image`
* Avoids `raw` directive disabled by PyPi
* Fixes #553

* Fix unexpected unindent in docs

Add copy of png file to render correctly in GitHub
readme and Sphinx generated docs.

* chore(main): release 3.1.1 (#557)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* Update env-tests submodule

* Minor format update

* Fix system test to skip diagnostic log entry

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update truncation logic based on feedback

* Update environment tests

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Fix broken unit test

* Fix broken unit test

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Change default name/version

* Refactor add_instrumentation

Return a new list instead of a mutated original
Do not return after first log without info

* Add more documentation to validation methods

* Refactor add_instrumentation to be more pythonic

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update environemnt tests

* Refactor _is_valid and add test

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Add more detail to method documentation

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Move methods to private

* Change instumentation_added to private

* Fix some issues with validation method

Add a test

* Fix bug in _add_instrumentation

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Simplify string truncation

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Remove unused import to fix lint

* Remove validate_and_update_instrumentation

Simplify code by adding a single instrumentation entry
instead of validating potential existing entries

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Remove _is_valid code (no longer checked)

* Run nox blacken

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Remove extraneous unit test

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Daniel Sanche <d.sanche14@gmail.com>
parthea added a commit that referenced this pull request Feb 13, 2026
feat: update image to
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:d7caef319a25d618e20ba798b103434700bfd80015f525802d87621ca2528c90

This PR was created using the following command

```
partheniou@partheniou-vm-3:~/git/proto-plus-python$ librarian update-image -push
...
time=2025-12-12T18:05:15.002Z level=INFO msg="successfully pushed changes" refSpec=+refs/heads/librarian-20251212T180513Z:refs/heads/librarian-20251212T180513Z
time=2025-12-12T18:05:15.002Z level=INFO msg="creating PR" branch=librarian-20251212T180513Z base=main title="chore: librarian update image pull request: 20251212T180513Z"
time=2025-12-12T18:05:16.170Z level=INFO msg="pr created" url=googleapis/proto-plus-python#554
time=2025-12-12T18:05:16.170Z level=INFO msg="labels added to issue" number=554 labels=[]
```
parthea added a commit that referenced this pull request Mar 2, 2026
parthea pushed a commit that referenced this pull request Mar 6, 2026
BREAKING CHANGE: DBAPI code was moved into python-spanner in
googleapis/python-spanner#160. This change removes it
from this repo and bumps the dependency on python-spanner to 2.0.0, the first
released version to include DBAPI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

5 participants