Skip to content

Speeding up lint by only considering files which are different. - #316

Merged
tseaver merged 1 commit into
googleapis:masterfrom
dhermes:speed-up-lint
Oct 29, 2014
Merged

Speeding up lint by only considering files which are different.#316
tseaver merged 1 commit into
googleapis:masterfrom
dhermes:speed-up-lint

Conversation

@dhermes

@dhermes dhermes commented Oct 29, 2014

Copy link
Copy Markdown
Contributor

H/T to @sk- and https://github.com/sk-/git-lint for the inspiration.

This is related to #290 but covers the last annoying slowdown we have. (At least as well as pylint allow.)
@coveralls

coveralls commented Oct 29, 2014

Copy link
Copy Markdown

Coverage Status

Coverage remained the same when pulling cdf9d55 on dhermes:speed-up-lint into ce7f890 on GoogleCloudPlatform:master.
@dhermes

dhermes commented Oct 29, 2014

Copy link
Copy Markdown
Contributor Author

w00t! Lint down from 80s to 11s:
https://travis-ci.org/GoogleCloudPlatform/gcloud-python/builds/39429969

Total time of 1m25s
@tseaver

tseaver commented Oct 29, 2014

Copy link
Copy Markdown
Contributor

LGTM: I'm all for a swifter valet.
@dhermes

dhermes commented Oct 29, 2014

Copy link
Copy Markdown
Contributor Author

@tseaver can you do the merge? I am AFK

On Wed, Oct 29, 2014, 3:12 PM Tres Seaver notifications@github.com wrote:

LGTM: I'm all for a swifter valet.

—
Reply to this email directly or view it on GitHub
#316 (comment)
.
tseaver added a commit that referenced this pull request Oct 29, 2014
@tseaver
Merge pull request #316 from dhermes/speed-up-lint
1e911e4 
Speeding up lint by only considering files which are different.
@tseaver
tseaver merged commit 1e911e4 into googleapis:master Oct 29, 2014
@dhermes
dhermes deleted the speed-up-lint branch October 30, 2014 19:04
parthea pushed a commit that referenced this pull request Jun 4, 2023
@renovate-bot
chore(deps): update dependency pytest to v7.1.2 (#316)
51f200b
parthea added a commit that referenced this pull request Jun 4, 2023
@renovate-bot @parthea
chore(deps): update dependency selenium to v4.6.0 (#316)
bd6ec54 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea added a commit that referenced this pull request Jun 4, 2023
@release-please @parthea
chore(main): release 1.5.0 (#316)
4ebffb1 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
build(deps): bump requests to 2.31.0 [autoapprove] (#316)
33d66e5 
Source-Link: https://togithub.com/googleapis/synthtool/commit/30bd01b4ab78bf1b2a425816e15b3e7e090993dd
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9bc5fa3b62b091f60614c08a7fb4fd1d3e1678e326f34dd66ce1eefb5dc3267b
parthea pushed a commit that referenced this pull request Jun 4, 2023
@renovate-bot
chore(deps): update dependency pytest to v7.2.1 (#316)
2f25809
parthea pushed a commit that referenced this pull request Jul 6, 2023
@gcf-owl-bot
chore(python): auto approve template changes (#316)
7dca0ad 
Source-Link: googleapis/synthtool@453a5d9
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:81ed5ecdfc7cac5b699ba4537376f3563f6f04122c4ec9e735d3b3dc1d43dd32
parthea pushed a commit that referenced this pull request Sep 20, 2023
@renovate-bot
chore(deps): update all dependencies (#316)
090a1dc
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
@gcf-owl-bot
docs: omit mention of Python 2.7 in 'CONTRIBUTING.rst' (#1127) (#316)
1679681 
Source-Link: googleapis/synthtool@b91f129
Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:b6169fc6a5207b11800a7c002d0c5c2bc6d82697185ca12e666f44031468cfcd
parthea added a commit that referenced this pull request Sep 22, 2023
@renovate-bot @parthea
chore(deps): update dependency pytest to v7.4.0 (#316)
cfbb09c 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore(python): Enable size-label bot (#316)
9393b68 
Source-Link: googleapis/synthtool@06e8279
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:b3500c053313dc34e07b1632ba9e4e589f4f77036a7cf39e1fe8906811ae0fce
parthea pushed a commit that referenced this pull request Sep 22, 2023
@renovate-bot
chore(deps): update dependency pytest to v7.2.0 (#316)
d1d6218
parthea pushed a commit that referenced this pull request Sep 22, 2023
@release-please
chore(main): release 2.14.0 (#316)
63b7e39 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore: use gapic-generator-python 0.58.4 (#316)
5deb1a4 
* chore: use gapic-generator-python 0.58.4

fix: provide appropriate mock values for message body fields

committer: dovs
PiperOrigin-RevId: 419025932

Source-Link: googleapis/googleapis@73da669

Source-Link: googleapis/googleapis-gen@46df624
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDZkZjYyNGE1NGI5ZWQ0N2MxYTdlZWZiN2E0OTQxM2NmN2I4MmY5OCJ9

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore: fix prerelease_deps nox session [autoapprove] (#316)
8225234 
Source-Link: https://togithub.com/googleapis/synthtool/commit/26c7505b2f76981ec1707b851e1595c8c06e90fc
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f946c75373c2b0040e8e318c5e85d0cf46bc6e61d0a01f3ef94d8de974ac6790
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore(python): update release script dependencies (#316)
ca57f1e 
Source-Link: googleapis/synthtool@25083af
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e6cbd61f1838d9ff6a31436dfc13717f372a7482a82fc1863ca954ec47bff8c8

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Sep 22, 2023
@parthea
fix(deps): allow protobuf < 5.0.0 (#316)
062cd59 
fix(deps): require proto-plus >= 1.22.0
parthea pushed a commit that referenced this pull request Sep 22, 2023
@renovate-bot
chore(deps): update dependency pytest to v7.1.2 (#316)
92b38be
parthea pushed a commit that referenced this pull request Oct 21, 2023
@release-please
chore: release 3.7.0 (#316)
23d0d46 
🤖 I have created a release \*beep\* \*boop\*
---
## [3.7.0](https://www.github.com/googleapis/python-asset/compare/v3.6.1...v3.7.0) (2021-10-12)


### Features

* add context manager support in client ([#314](https://www.github.com/googleapis/python-asset/issues/314)) ([659db45](https://www.github.com/googleapis/python-asset/commit/659db456ff6cc7a09fffd83479b2b43d5905239f))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore(deps): update actions/setup-python action to v4 [autoapprove] (#…
5250c1c 
…316)

Source-Link: googleapis/synthtool@8e55b32
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c6c965a4bf40c19011b11f87dbc801a66d3a23fbc6704102be064ef31c51f1c3
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore: remove 'pip install' statements from python_library templates …
5386c03 
…[autoapprove] (#316)

Source-Link: googleapis/synthtool@1f37ce7
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8e84e0e0d71a0d681668461bba02c9e1394c785f31a10ae3470660235b673086
parthea added a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot @parthea
chore: use gapic-generator-python 0.65.2 (#316)
989a3b0 
* chore: use gapic-generator-python 0.65.2

PiperOrigin-RevId: 444333013

Source-Link: googleapis/googleapis@f91b6cf

Source-Link: googleapis/googleapis-gen@16eb360
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTZlYjM2MDk1YzI5NGU3MTJjNzRhMWJmMjM1NTA4MTdiNDIxNzRlNSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore(deps): update actions/checkout action to v3 (#316)
4bc0432 
Source-Link: googleapis/synthtool@ca87909
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6162c384d685c5fe22521d3f37f6fc732bf99a085f6d47b677dbcae97fc21392
parthea pushed a commit that referenced this pull request Oct 21, 2023
@renovate-bot
chore(deps): update dependency pytest to v7.2.1 (#316)
c08f3e7
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore: Update gapic-generator-python to v1.6.1 (#316)
5d1db32 
* chore: Update gapic-generator-python to v1.6.1

PiperOrigin-RevId: 488036204

Source-Link: googleapis/googleapis@08f275f

Source-Link: googleapis/googleapis-gen@555c094
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTU1YzA5NDVlNjA2NDllMzg3MzlhZTY0YmM0NTcxOWNkZjcyMTc4ZiJ9

* chore: Update gapic-generator-python to v1.6.1

PiperOrigin-RevId: 488036204

Source-Link: googleapis/googleapis@08f275f

Source-Link: googleapis/googleapis-gen@555c094
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTU1YzA5NDVlNjA2NDllMzg3MzlhZTY0YmM0NTcxOWNkZjcyMTc4ZiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Oct 21, 2023
@renovate-bot @parthea
fix(deps): allow google-cloud-storage < 3.0.0dev (#316)
2f9abae 
* chore(deps): update dependency google-cloud-storage to v2

* fix(deps): allow google-cloud-storage < 3.0.0dev

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@joshuamo Aaron Gabriel Neyer
chore(python): Add example of using client_options for regional endpo…
e9de14f 
…ints (#316)

* Add example of using client_options for regional endpoints

* Add example of using client_options for regional endpoints

* Add example of using client_options for regional endpoints

* Add example of using client_options for regional endpoints

Co-authored-by: Aaron Gabriel Neyer <aarongabriel@google.com>
parthea pushed a commit that referenced this pull request Oct 22, 2023
@gcf-owl-bot
chore: remove pinned Sphinx version [autoapprove] (#316)
5cd4245 
Source-Link: https://togithub.com/googleapis/synthtool/commit/909573ce9da2819eeb835909c795d29aea5c724e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ddf4551385d566771dc713090feb7b4c1164fb8a698fe52bbe7670b24236565b
parthea pushed a commit that referenced this pull request Aug 21, 2025
@gcf-owl-bot
chore: fail samples nox session if python version is missing (#316)
e9517c2
parthea pushed a commit that referenced this pull request Sep 16, 2025
@gcf-owl-bot @parthea
chore: fail samples nox session if python version is missing (#316)
adf386b
parthea added a commit that referenced this pull request Nov 22, 2025
@parthea
chore: delete unused protos (#316)
6a12cb7
parthea pushed a commit that referenced this pull request Nov 24, 2025
@gcf-owl-bot
chore(python): conditionally load credentials in .kokoro/build.sh (#316)
c28289e 
Source-Link: googleapis/synthtool@aa69fb7
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f016446d6e520e5fb552c45b110cba3f217bffdd3d06bdddd076e9e6d13266cf

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
@gcf-owl-bot
chore: update docfx minimum Python version (#316)
3e6b41c 
Source-Link: googleapis/synthtool@bc07fd4
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:30470597773378105e239b59fce8eb27cc97375580d592699206d17d117143d0

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
@release-please
chore(main): release 1.20.5 (#316)
d566c8d 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Nov 24, 2025
@release-please @busunkim96 @parthea
chore: release 2.4.0 (#316)
75b411b 
* chore: release 2.4.0

* chore: delete #318 from log (already released)

* Update changelog to include published versions

* insert newline in changelog

* insert newline in changelog

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
@gcf-owl-bot
chore(python): fix docs publish build (#316)
f68fd8d 
Source-Link: googleapis/synthtool@bd9ede2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:04c35dc5f49f0f503a306397d6d043685f8d2bb822ab515818c4208d7fb2db3a

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
@release-please
chore(main): release 2.6.1 (#316)
6c5db6e 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
@chelsea-lin
feat: add __hash__ property for JSONArrowType (#316)
16a4abd
parthea added a commit that referenced this pull request Nov 24, 2025
@parthea
fix: remove setup.cfg configuration for creating universal wheels (#316)
dfb331f
parthea pushed a commit that referenced this pull request Nov 24, 2025
@holtskinner
fix: Refactor page.py to improve performance and organization (#316)
3ede3cb 
Fixes #312 🦕

Improves upon the hOCR processing improvements made in #313
parthea pushed a commit that referenced this pull request Nov 24, 2025
@craiglabenz @craiglabenz-g
refactor: removing usage of GetDocument proto in favor of BatchGetDoc…
8e33c0e 
…uments (#316)

* Began refactoring away from GetDocument proto

which contains no `read_time` field and in general is a shortcut around `BatchGetDocuments`

* Correctly instantiate snapshots for missing documents

* Removed stale NotFound exception

* Removed unnecessary empty list check

* Linting fix

* Expanded batch_get change to async classes

* Updated variable name

* Added get_batch to async classes

* Improved consumption of async generators

* Fixed test coverage

* Fixed broken mock in test

* Linting

* Reverted the move of AsyncIter

Co-authored-by: Craig Labenz <craiglabenz@google.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
@daniel-sanche
feat!: support json logs (#316)
02eccc5
parthea pushed a commit that referenced this pull request Nov 25, 2025
@daniel-sanche
feat!: support json logs (#316)
8520cc1
parthea pushed a commit that referenced this pull request Mar 2, 2026
@release-please
chore(main): release 2.3.2 (#316)
3ff3f42 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Mar 9, 2026
@asthamohta
feat: enable instance-level connection (#316)
7e8e733 
* chore: auto-release

* feat:enable instance-level connection

* lint
parthea pushed a commit that referenced this pull request Mar 9, 2026
@andrewsg
fix: retry uploads only conditionally (#316)
865c446 
* fix: retry uploads only conditionally

* update docstring for num_retries
parthea pushed a commit that referenced this pull request Mar 9, 2026
@vi3k6i5
feat: added support for numeric field for python decimal value (#316)
efb0783 
* feat: updated googleapis proto changes for request tags

* feat: added support for numberic for python decimal value

* feat: added support for numberic for python decimal value
parthea added a commit that referenced this pull request Mar 9, 2026
@gcf-owl-bot @parthea
chore: rename rst files to avoid conflict with service names (#316)
ff15676 
Source-Link: googleapis/synthtool@d52e638
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:4f9b3b106ad0beafc2c8a415e3f62c1a0cc23cabea115dbe841b848f581cfe99

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing

3 participants

@dhermes @coveralls @tseaver