Making all modules in gcloud package pylint compliant. by dhermes · Pull Request #210 · googleapis/google-cloud-python

dhermes · 2014-10-02T23:16:35Z

No description provided.

tseaver · 2014-10-03T00:05:03Z

Rather than sprinkling the code with comments to turn off pylint stuff, I'd rather we added a '.pylintrc' file (or whatever it should be called) which spells out the styles as we want to test them.

For instance, instead of '# pylint: disable=C0103' for a testcase method name which pylint believes is too long, we could override the regex it is using to permit longer names.

I'd also suggest that we add a new tox environment, e.g., 'tox -e lint', which runs all the hygeine checkers we want (pep8, pylint, etc.) using our defined rules, and fails (to cause PRs to be flagged).

dhermes · 2014-10-03T00:16:16Z

I am a big fan of a custom pylintrc file, and I think we can cover 99% of things with one. However, there is a caveat.

I don't think we will be able to avoid using pylint: disable comments without tearing our hair out every time we come across some sharp corner we hadn't thought of.

I had never thought of the comments as a nuisance (they are everywhere in Google's codebase and many others) and the pylint people intend for them to be used in that fashion.

Yes, #178 is in place (partly) with such a new tox rule in mind.

tseaver · 2014-10-03T00:19:40Z

Those comments smell to me: tools should serve the developers and their code, not the other way 'round.

dhermes · 2014-10-03T00:36:33Z

Yeah I like the idea, it's just new to me.

Let's see how far we can take it with a pylintrc. The first few things that come to mind:

In tests, turn off invalid-name (C0103), protected-access, too-many-public-methods (R0904), too-few-public-methods, and missing-docstring
Don't check __init__.py when it is mostly empty

In 7e98f53 I got rid of a few of the pylint disable statements already and will keep working on this.

…tion.

dhermes · 2014-10-04T22:57:27Z

I'm working on breaking this off into pieces:

silvolu · 2014-10-07T00:10:39Z

Can I merge this one or is it either this one or #221?

dhermes · 2014-10-07T01:43:13Z

This one will likely be abandoned since we're trying to minimize the number of pylint: disable comments in our code (prefer to attain the minimum of 0). However I want to get #217 in before anything else code-quality related.

tseaver · 2014-10-07T03:18:59Z

I just merged #217.

dhermes · 2014-10-07T03:42:57Z

Let's finish any discussion on #221 and then I can ask for another look here pending those results.

dhermes · 2014-10-07T15:29:28Z

Closing this so people don't think it should be merged. Will re-open if need be after #221.

dhermes · 2014-10-13T20:48:13Z

This is officially dead (won't be re-opened after #221) due to #238

FWIW all these are in #238.

Ability to create, and edit listitems in sharepoint

…versions (#210) Expand pins on library dependencies in preparation for these dependencies taking a new major version. See #10565.

* fix: fix type in docstring for map fields PiperOrigin-RevId: 440107808 Source-Link: googleapis/googleapis@258ddb2 Source-Link: googleapis/googleapis-gen@df0d09a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGYwZDA5YTJjMzZmZjViYWY5ODY0OGVlZmU1MDI5YzE3MzkwNWQwYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md PiperOrigin-RevId: 440123036 Source-Link: googleapis/googleapis@bc99550 Source-Link: googleapis/googleapis-gen@a0e1d65 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYTBlMWQ2NTE1MTI4NzIyYzhjMTYyMTM4N2VhYjM3ODE4NjEyMjc5OCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…210) Source-Link: googleapis/synthtool@95d9289 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c8878270182edaab99f2927969d4f700c3af265accd472c3425deedff2b7fd93 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@52e4e46 Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:6186535cbdbf6b9fe61f00294929221d060634dae4a0795c1cefdbc995b2d605

🤖 I have created a release \*beep\* \*boop\* --- ### [3.2.2](https://www.github.com/googleapis/python-dlp/compare/v3.2.1...v3.2.2) (2021-07-27) ### Bug Fixes * enable self signed jwt for grpc ([#218](https://www.github.com/googleapis/python-dlp/issues/218)) ([584a887](https://www.github.com/googleapis/python-dlp/commit/584a887ac2bb648ebac439d4044f3fd8f12a01f4)) ### Documentation * add Samples section to CONTRIBUTING.rst ([#210](https://www.github.com/googleapis/python-dlp/issues/210)) ([566827b](https://www.github.com/googleapis/python-dlp/commit/566827ba4cead4a5237fed370da132dd6fb55602)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Source-Link: googleapis/synthtool@4760d8d Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f0e4b51deef56bed74d3e2359c583fc104a8d6367da3984fc5c66938db738828 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release \*beep\* \*boop\* --- ### [2.7.1](https://www.github.com/googleapis/python-texttospeech/compare/v2.7.0...v2.7.1) (2021-11-01) ### Bug Fixes * **deps:** drop packaging dependency ([99ac70b](https://www.github.com/googleapis/python-texttospeech/commit/99ac70ba45d7c500d0f19a30dead060c0db4453c)) * **deps:** require google-api-core >= 1.28.0 ([99ac70b](https://www.github.com/googleapis/python-texttospeech/commit/99ac70ba45d7c500d0f19a30dead060c0db4453c)) ### Documentation * list oneofs in docstring ([99ac70b](https://www.github.com/googleapis/python-texttospeech/commit/99ac70ba45d7c500d0f19a30dead060c0db4453c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-videointelligence/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #178🦕

Source-Link: https://togithub.com/googleapis/synthtool/commit/25083af347468dd5f90f69627420f7d452b6c50e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e6cbd61f1838d9ff6a31436dfc13717f372a7482a82fc1863ca954ec47bff8c8

Source-Link: googleapis/synthtool@b0eb8a8 Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:df50e8d462f86d6bcb42f27ecad55bb12c404f1c65de9c6fe4c4d25120080bd6

) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [google-cloud-texttospeech](https://togithub.com/googleapis/python-texttospeech) | `==2.5.0` -> `==2.5.1` | [![age](https://badges.renovateapi.com/packages/pypi/google-cloud-texttospeech/2.5.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/google-cloud-texttospeech/2.5.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/google-cloud-texttospeech/2.5.1/compatibility-slim/2.5.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/google-cloud-texttospeech/2.5.1/confidence-slim/2.5.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/python-texttospeech</summary> ### [`v2.5.1`](https://togithub.com/googleapis/python-texttospeech/blob/master/CHANGELOG.md#251-httpswwwgithubcomgoogleapispython-texttospeechcomparev250v251-2021-07-20) [Compare Source](https://togithub.com/googleapis/python-texttospeech/compare/v2.5.0...v2.5.1) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/python-translate).

🤖 I have created a release \*beep\* \*boop\* --- ### [2.4.2](https://www.github.com/googleapis/python-vision/compare/v2.4.1...v2.4.2) (2021-07-29) ### Bug Fixes * enable self signed jwt for grpc ([#207](https://www.github.com/googleapis/python-vision/issues/207)) ([f5b5ca5](https://www.github.com/googleapis/python-vision/commit/f5b5ca52aaa04dbe91dcf32097309e00593b5ce9)) ### Documentation * add Samples section to CONTRIBUTING.rst ([#201](https://www.github.com/googleapis/python-vision/issues/201)) ([f6eaa1c](https://www.github.com/googleapis/python-vision/commit/f6eaa1c0a89258f9378672b8713990fc10cea0c9)) ### Miscellaneous Chores * release as 2.4.2 ([#209](https://www.github.com/googleapis/python-vision/issues/209)) ([8d48b1b](https://www.github.com/googleapis/python-vision/commit/8d48b1b2284da8eff95190478292f5422d59a2f1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Source-Link: googleapis/synthtool@52e4e46 Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:6186535cbdbf6b9fe61f00294929221d060634dae4a0795c1cefdbc995b2d605

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

…pprove] (#210) Source-Link: https://togithub.com/googleapis/synthtool/commit/e3a1277ac35fc88c09db1930533e24292b132ced Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:452901c74a22f9b9a3bd02bce780b8e8805c97270d424684bff809ce5be8c2a2

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 472772457 Source-Link: googleapis/googleapis@855b74d Source-Link: googleapis/googleapis-gen@b64b1e7 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjY0YjFlN2RhM2UxMzhmMTVjYTM2MTU1MmVmMDU0NWU1NDg5MWI0ZiJ9

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

…210) Source-Link: https://togithub.com/googleapis/synthtool/commit/395d53adeeacfca00b73abf197f65f3c17c8f1e9 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6c1cbc75c74b8bdd71dada2fa1677e9d6d78a889e9a70ee75b93d1d0543f96e1

…versions (#210) Expand pins on library dependencies in preparation for these dependencies taking a new major version. See #10565.

Source-Link: googleapis/synthtool@eb78c98 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8a5d3f6a2e43ed8293f34e06a2f56931d1e88a2694c3bb11b15df4eb256ad163 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: https://togithub.com/googleapis/synthtool/commit/92006bb3cdc84677aa93c7f5235424ec2b157146 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2e247c7bf5154df7f98cce087a20ca7605e236340c7d6d1a14447e5c06791bd6

beriberikix added the in progress label Oct 2, 2014

dhermes mentioned this pull request Oct 2, 2014

Add PEP8 linting to Travis build rule #178

Closed

dhermes added the hygiene label Oct 2, 2014

dhermes force-pushed the pylint-gcloud-dir branch from 0d1a55c to 35b0f10 Compare October 2, 2014 23:22

dhermes force-pushed the pylint-gcloud-dir branch 2 times, most recently from 316a825 to 7591229 Compare October 3, 2014 00:29

dhermes added 2 commits October 3, 2014 08:08

Making all modules in gcloud package pylint compliant.

ac1b1b4

Using staticmethods when self not used.

24468ff

dhermes force-pushed the pylint-gcloud-dir branch from 7e98f53 to 24468ff Compare October 3, 2014 15:08

Adding pylint ignore for type confusion in pkg_resources.get_distribu…

cd78230

…tion.

dhermes mentioned this pull request Oct 4, 2014

Adding base pylint rcfile and plugin for unittests. #221

Closed

dhermes closed this Oct 7, 2014

beriberikix removed the in progress label Oct 7, 2014

dhermes deleted the pylint-gcloud-dir branch October 18, 2014 01:39

dhermes mentioned this pull request Feb 4, 2015

Add python 3.4 #580

Merged

urshala pushed a commit to urshala/google-cloud-python that referenced this pull request Jan 17, 2020

Merge pull request googleapis#210 from jtweeder/sharepoint_list_edit

d45e78b

Ability to create, and edit listitems in sharepoint

atulep pushed a commit that referenced this pull request Apr 3, 2023

fix(deps): pin 'google-{api,cloud}-core', 'google-auth' to allow 2.x …

8bf884e

…versions (#210) Expand pins on library dependencies in preparation for these dependencies taking a new major version. See #10565.

atulep pushed a commit that referenced this pull request Apr 6, 2023

fix(deps): pin 'google-{api,cloud}-core', 'google-auth' to allow 2.x …

72067a9

…versions (#210) Expand pins on library dependencies in preparation for these dependencies taking a new major version. See #10565.

atulep pushed a commit that referenced this pull request Apr 6, 2023

fix(deps): pin 'google-{api,cloud}-core', 'google-auth' to allow 2.x …

ed69c72

…versions (#210) Expand pins on library dependencies in preparation for these dependencies taking a new major version. See #10565.

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency pytest to v6.2.5 (#210)

f8d6c02

parthea pushed a commit that referenced this pull request Sep 22, 2023

build: switch to release-please for tagging (#210)

e6b417a

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency google-cloud-storage to v1.39.0 (#210)

88975f7

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency pytest to v7.1.1 (#210)

400327b

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency cryptography to v36 (#210)

5ea622c

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-monitoring to v2.5.0 (#210)

014bb02

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency pytest to v7.1.1 (#210)

6c64bf6

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(main): release 1.6.1 (#210)

4c85874

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea added a commit that referenced this pull request Oct 21, 2023

chore: update .repo-metadata.json (#210)

6ce3afc

parthea pushed a commit that referenced this pull request Oct 22, 2023

chore(main): release 2.7.1 (#210)

3034633

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Oct 22, 2023

fix(deps): pin 'google-{api,cloud}-core', 'google-auth' to allow 2.x …

c6ed0a3

…versions (#210) Expand pins on library dependencies in preparation for these dependencies taking a new major version. See #10565.

parthea pushed a commit that referenced this pull request Sep 18, 2025

Prepare for 0.6.1 release. (#210)

3d98b0f

Navigation Menu

Uh oh!

Making all modules in gcloud package pylint compliant. - #210

Making all modules in gcloud package pylint compliant.#210
dhermes wants to merge 3 commits into
googleapis:masterfrom
dhermes:pylint-gcloud-dir

dhermes commented Oct 2, 2014

tseaver commented Oct 3, 2014

dhermes commented Oct 3, 2014

tseaver commented Oct 3, 2014

dhermes commented Oct 3, 2014

dhermes commented Oct 4, 2014

silvolu commented Oct 7, 2014

dhermes commented Oct 7, 2014

tseaver commented Oct 7, 2014

dhermes commented Oct 7, 2014

dhermes commented Oct 7, 2014

dhermes commented Oct 13, 2014

Labels

4 participants

Uh oh!

Conversation

dhermes commented Oct 2, 2014

tseaver commented Oct 3, 2014

dhermes commented Oct 3, 2014

tseaver commented Oct 3, 2014

dhermes commented Oct 3, 2014

dhermes commented Oct 4, 2014

silvolu commented Oct 7, 2014

dhermes commented Oct 7, 2014

tseaver commented Oct 7, 2014

dhermes commented Oct 7, 2014

dhermes commented Oct 7, 2014

dhermes commented Oct 13, 2014

Labels

4 participants