Loosen lbfgsb_test Rosenbrock tolerance to 1.5e-3#641
Open
seantalts wants to merge 1 commit into
Open
Conversation
The L-BFGS-B test asserts the Rosenbrock function value is <= 1e-3 at the optimizer's output, but this is flaky across platforms/backends where the optimizer terminates just shy of that bound. Loosen the tolerance to 1.5e-3.
Contributor
Author
|
@vroulet could you take a look? Small test-tolerance bump — a recent XLA:CPU strength-reduction change to batched vector-vector products introduced fp noise that pushes the Rosenbrock value just over the old |
Collaborator
|
The library is no longer maintained, so failing test do not matter I believe. Why do you ask? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update tolerance - a recent XLA:CPU change to strength reduction of batched vector vector products made this fail due to fp noise.