Skip to content

Revert "Bump major version to v29" - #1366

Merged
gmlewis merged 1 commit into
masterfrom
revert-1344-v29
Jan 8, 2020
Merged

Revert "Bump major version to v29"#1366
gmlewis merged 1 commit into
masterfrom
revert-1344-v29

Conversation

@gmlewis

@gmlewis gmlewis commented Jan 8, 2020

Copy link
Copy Markdown
Collaborator

Reverts #1344 due to breaking the build.

@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Jan 8, 2020
@gmlewis

gmlewis commented Jan 8, 2020

Copy link
Copy Markdown
Collaborator Author

Merging to fix build. I'll address v29 later tonight. Sorry for all the noise. :-(

@gmlewis
gmlewis merged commit 26c91e4 into master Jan 8, 2020
@gmlewis
gmlewis deleted the revert-1344-v29 branch January 8, 2020 22:12
@dmitshur

dmitshur commented Jan 8, 2020

Copy link
Copy Markdown
Member

No problem @gmlewis, thank you for taking care of this.

I believe the issue in PR #1344 was that it did not update the recently added example/topics/main.go file, it still imports "github.com/google/go-github/v28/github" instead of "github.com/google/go-github/v29/github": https://github.com/google/go-github/blob/v29.0.0/example/topics/main.go#L15.

After we fix this, we'll need to pick a new version number, because v29.0.0 has already been published. Perhaps v29.0.1, since this will be fixing up a minor problem.

@gmlewis

gmlewis commented Jan 8, 2020

Copy link
Copy Markdown
Collaborator Author

Ah, thank you for the analysis, @dmitshur !
I'm going to try and remedy it now.
(I deleted the v29.0.0 if that makes any difference.)

@dmitshur

dmitshur commented Jan 9, 2020

Copy link
Copy Markdown
Member

(I deleted the v29.0.0 if that makes any difference.)

That version has already been indexed and added to the Go checksum database, so we still won't be able to publish the same module version with different content without it causing a mismatch in the hash.

n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indication that the PR author has signed a Google Contributor License Agreement.

3 participants