Skip to content

builtin: Implement builtin_bin - #70

Merged
corona10 merged 1 commit into
go-python:masterfrom
corona10:builtin_bin
Aug 12, 2019
Merged

builtin: Implement builtin_bin#70
corona10 merged 1 commit into
go-python:masterfrom
corona10:builtin_bin

Conversation

@corona10

Copy link
Copy Markdown
Collaborator

Implementation of builtin bin

@corona10
corona10 requested a review from ncw August 12, 2019 15:57
@codecov-io

codecov-io commented Aug 12, 2019

Copy link
Copy Markdown

Codecov Report

Merging #70 into master will increase coverage by 0.01%.
The diff coverage is 86.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   68.63%   68.65%   +0.01%     
==========================================
  Files          59       59              
  Lines       10512    10525      +13     
==========================================
+ Hits         7215     7226      +11     
- Misses       2789     2790       +1     
- Partials      508      509       +1
Impacted Files Coverage Δ
builtin/builtin.go 79.67% <84.61%> (+0.11%) ⬆️
py/bigint.go 66.02% <87.5%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fff175c...f515870. Read the comment docs.

@corona10

Copy link
Copy Markdown
Collaborator Author

@ncw please take a look

@ncw ncw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect :-)

LGTM

@corona10
corona10 merged commit 7bc4005 into go-python:master Aug 12, 2019
@corona10
corona10 deleted the builtin_bin branch August 12, 2019 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants