Skip to content

builtin: Implement delattr - #55

Merged
corona10 merged 1 commit into
go-python:masterfrom
corona10:builtin_delattr
Feb 15, 2019
Merged

builtin: Implement delattr#55
corona10 merged 1 commit into
go-python:masterfrom
corona10:builtin_delattr

Conversation

@corona10

@corona10 corona10 commented Feb 14, 2019

Copy link
Copy Markdown
Collaborator

I've implemented delattr for builtin function.

@corona10
corona10 requested a review from ncw February 14, 2019 17:53
@codecov-io

codecov-io commented Feb 14, 2019

Copy link
Copy Markdown

Codecov Report

Merging #55 into master will increase coverage by 0.01%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   66.42%   66.44%   +0.01%     
==========================================
  Files          59       59              
  Lines       10368    10379      +11     
==========================================
+ Hits         6887     6896       +9     
- Misses       2989     2990       +1     
- Partials      492      493       +1
Impacted Files Coverage Δ
builtin/builtin.go 79.62% <81.81%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 344a390...c625d39. Read the comment docs.

@corona10

Copy link
Copy Markdown
Collaborator Author

@ncw
Please take a look.
This is a pretty easy PR then before. :)

I'd like to see that gpython could run stdlib in this year.
I expect that we must update some object structure.
And this will be a rough road.

@ncw ncw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm :-)

@corona10
corona10 merged commit 0c9eac8 into go-python:master Feb 15, 2019
@corona10
corona10 deleted the builtin_delattr branch February 15, 2019 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants