Skip to content

parser: Update make_grammer_text.py - #37

Merged
ncw merged 1 commit into
go-python:masterfrom
corona10:fix_pr_22
Nov 25, 2018
Merged

parser: Update make_grammer_text.py#37
ncw merged 1 commit into
go-python:masterfrom
corona10:fix_pr_22

Conversation

@corona10

@corona10 corona10 commented Nov 24, 2018

Copy link
Copy Markdown
Collaborator

While I work on issue #32. I found that I did not notice that
grammar_data_test.go is the auto-generated file.

So I add the test cases for #22 and also implement auto-generated license file

@corona10
corona10 requested review from ncw and sbinet November 24, 2018 07:47
- Support auto-generated license header based on created time.
- Add missed case when adding test cases go-python#22
@codecov-io

codecov-io commented Nov 24, 2018

Copy link
Copy Markdown

Codecov Report

Merging #37 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #37   +/-   ##
=======================================
  Coverage   65.23%   65.23%           
=======================================
  Files          56       56           
  Lines       10151    10151           
=======================================
  Hits         6622     6622           
  Misses       3067     3067           
  Partials      462      462

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b715616...9198567. Read the comment docs.

@corona10

Copy link
Copy Markdown
Collaborator Author

@ncw @sbinet PTAL

@ncw

ncw commented Nov 25, 2018

Copy link
Copy Markdown
Collaborator

Well spotted :-)

@ncw
ncw merged commit 0773b68 into go-python:master Nov 25, 2018
@corona10
corona10 deleted the fix_pr_22 branch November 25, 2018 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants