Skip to content

resolved benign Go warnings - #153

Merged
sbinet merged 1 commit into
go-python:masterfrom
drew-512:hotfix-address-benign-warnings
Jan 31, 2022
Merged

resolved benign Go warnings#153
sbinet merged 1 commit into
go-python:masterfrom
drew-512:hotfix-address-benign-warnings

Conversation

@drew-512

Copy link
Copy Markdown
Contributor

Inserted non-affecting changes to resolve Go warnings

@codecov

codecov Bot commented Jan 29, 2022

Copy link
Copy Markdown

Codecov Report

Merging #153 (e867ef0) into master (965bc08) will decrease coverage by 0.00%.
The diff coverage is 53.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
- Coverage   74.54%   74.54%   -0.01%     
==========================================
  Files          64       64              
  Lines       11182    11178       -4     
==========================================
- Hits         8336     8333       -3     
- Misses       2296     2297       +1     
+ Partials      550      548       -2     
Impacted Files Coverage Δ
compile/compile.go 90.56% <ø> (-0.01%) ⬇️
marshal/marshal.go 2.95% <0.00%> (ø)
py/code.go 11.90% <0.00%> (ø)
py/int.go 76.87% <0.00%> (-0.53%) ⬇️
py/method.go 70.52% <0.00%> (ø)
py/range.go 86.30% <ø> (-0.10%) ⬇️
py/bytes.go 28.07% <50.00%> (ø)
builtin/builtin.go 79.86% <100.00%> (+0.10%) ⬆️
parser/stringescape.go 100.00% <100.00%> (ø)
py/string.go 91.26% <100.00%> (-0.04%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 965bc08...e867ef0. Read the comment docs.

@sbinet sbinet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sbinet
sbinet merged commit 3068cb5 into go-python:master Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants