Skip to content

cs: Query for ZipSlip vulnerability (CVE-2018-1002200) - #54

Merged
semmle-qlci merged 6 commits into
github:masterfrom
denislevin:denisl/cs/ZipSlip
Aug 16, 2018
Merged

cs: Query for ZipSlip vulnerability (CVE-2018-1002200)#54
semmle-qlci merged 6 commits into
github:masterfrom
denislevin:denisl/cs/ZipSlip

Conversation

@denislevin

Copy link
Copy Markdown
Contributor

Initial check in to validate the tests

Initial check in to validate the tests
@denislevin
denislevin requested a review from a team as a code owner August 13, 2018 22:00
@ghost

ghost commented Aug 13, 2018

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@calumgrant

Copy link
Copy Markdown
Contributor

I have created a pull request against your branch to fix the failing unit tests.
denislevin#1

@calumgrant calumgrant left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! We can merge this once you have removed the @precision tag and the tests pass. @lukecartey has some further work on this and we can add qhelp as well.

Comment thread csharp/ql/src/Security Features/CWE-022/ZipSlip.ql Outdated
@denislevin

Copy link
Copy Markdown
Contributor Author

Removed @precision tag, merged unit test fixes from #1 branch

@lcartey

lcartey commented Aug 15, 2018

Copy link
Copy Markdown
Contributor

Thanks @denislevin. This is ready to merge apart from the CLA, which was updated this morning, so unfortunately you'll need to sign it again - sorry about that!

@denislevin

denislevin commented Aug 16, 2018 via email

Copy link
Copy Markdown
Contributor Author
@lcartey

lcartey commented Aug 16, 2018

Copy link
Copy Markdown
Contributor

@denislevin Sorry, I should have mentioned what changed. We've updated the formatting, and corrected our company name. You can see a full diff of the changes here:

https://gist.github.com/semmle-cla/577697e169c751bae58e29998f86a4f6/revisions

The CLA document is also available in the repository here:

https://github.com/Semmle/ql/blob/master/CONTRIBUTING.md

@semmle-qlci
semmle-qlci merged commit 83c539a into github:master Aug 16, 2018
aibaars pushed a commit that referenced this pull request Oct 14, 2021
Mark more AST predicates as `final`
smowton pushed a commit to smowton/codeql that referenced this pull request Oct 28, 2021
erik-krogh pushed a commit to erik-krogh/ql that referenced this pull request Dec 15, 2021
erik-krogh pushed a commit to erik-krogh/ql that referenced this pull request Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants