Auto-update dependencies.#2815
Conversation
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
There was a problem hiding this comment.
Code Review
This pull request updates the uiautomator dependency version from 2.3.0 to 2.4.0 across multiple modules and bumps the composeBom version in the Gradle Version Catalog. The reviewer suggests centralizing the uiautomator dependency definition within the Version Catalog (gradle/libs.versions.toml) rather than hardcoding it in individual module build files to ensure consistency.
| androidTestImplementation("androidx.test.espresso:espresso-core:3.7.0") | ||
| androidTestImplementation("androidx.test:rules:1.7.0") | ||
| androidTestImplementation("androidx.test.uiautomator:uiautomator:2.3.0") | ||
| androidTestImplementation("androidx.test.uiautomator:uiautomator:2.4.0") |
There was a problem hiding this comment.
Instead of hardcoding the dependency version directly in the module's build.gradle.kts file, it is highly recommended to manage it centrally using the Gradle Version Catalog (gradle/libs.versions.toml). This ensures consistency across all modules in this multi-module project.
Suggested Action:
- Add the version and library definition to
gradle/libs.versions.toml:[versions] uiautomator = "2.4.0" [libraries] androidx-test-uiautomator = { group = "androidx.test.uiautomator", name = "uiautomator", version.ref = "uiautomator" }
- Reference it here using the catalog alias.
androidTestImplementation(libs.androidx.test.uiautomator)| androidTestImplementation("androidx.test:rules:1.7.0") | ||
| androidTestImplementation("androidx.test:runner:1.7.0") | ||
| androidTestImplementation("androidx.test.uiautomator:uiautomator:2.3.0") | ||
| androidTestImplementation("androidx.test.uiautomator:uiautomator:2.4.0") |
There was a problem hiding this comment.
Instead of hardcoding the dependency version directly in the module's build.gradle.kts file, it is highly recommended to manage it centrally using the Gradle Version Catalog (gradle/libs.versions.toml). This ensures consistency across all modules in this multi-module project.
Suggested Action:
- Add the version and library definition to
gradle/libs.versions.toml:[versions] uiautomator = "2.4.0" [libraries] androidx-test-uiautomator = { group = "androidx.test.uiautomator", name = "uiautomator", version.ref = "uiautomator" }
- Reference it here using the catalog alias.
androidTestImplementation(libs.androidx.test.uiautomator)| androidTestImplementation("androidx.test:rules:1.7.0") | ||
| androidTestImplementation("androidx.test:runner:1.7.0") | ||
| androidTestImplementation("androidx.test.uiautomator:uiautomator:2.3.0") | ||
| androidTestImplementation("androidx.test.uiautomator:uiautomator:2.4.0") |
There was a problem hiding this comment.
Instead of hardcoding the dependency version directly in the module's build.gradle.kts file, it is highly recommended to manage it centrally using the Gradle Version Catalog (gradle/libs.versions.toml). This ensures consistency across all modules in this multi-module project.
Suggested Action:
- Add the version and library definition to
gradle/libs.versions.toml:[versions] uiautomator = "2.4.0" [libraries] androidx-test-uiautomator = { group = "androidx.test.uiautomator", name = "uiautomator", version.ref = "uiautomator" }
- Reference it here using the catalog alias.
androidTestImplementation(libs.androidx.test.uiautomator)| androidTestImplementation("androidx.test.espresso:espresso-core:3.7.0") | ||
| androidTestImplementation("androidx.test:rules:1.7.0") | ||
| androidTestImplementation("androidx.test.uiautomator:uiautomator:2.3.0") | ||
| androidTestImplementation("androidx.test.uiautomator:uiautomator:2.4.0") |
There was a problem hiding this comment.
Instead of hardcoding the dependency version directly in the module's build.gradle.kts file, it is highly recommended to manage it centrally using the Gradle Version Catalog (gradle/libs.versions.toml). This ensures consistency across all modules in this multi-module project.
Suggested Action:
- Add the version and library definition to
gradle/libs.versions.toml:[versions] uiautomator = "2.4.0" [libraries] androidx-test-uiautomator = { group = "androidx.test.uiautomator", name = "uiautomator", version.ref = "uiautomator" }
- Reference it here using the catalog alias.
androidTestImplementation(libs.androidx.test.uiautomator)
Brought to you by your friendly Repository Gardener.