-
Notifications
You must be signed in to change notification settings - Fork 57
Kube docs #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Kube docs #321
Conversation
Signed-off-by: Varun Mittal <varunmittal91@gmail.com>
15b9e15 to
b658d40
Compare
|
|
||
| - **Scalability:** Automatically scale your conversion jobs horizontally by increasing or decreasing the number of pods | ||
| based | ||
| on the workload. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove line break
| - **Persistent Volumes:** Persistent storage is used to store the input and output data, as well as any intermediate | ||
| state, ensuring data persistence across pod restarts. | ||
| - **Jobs:** For conversion tasks that need to be executed as a one-off job, Kubernetes | ||
| Jobs can manage these execution patterns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - **Persistent Volumes:** Persistent storage is used to store the input and output data, as well as any intermediate | ||
| state, ensuring data persistence across pod restarts. | ||
| - **Jobs:** For conversion tasks that need to be executed as a one-off job, Kubernetes | ||
| Jobs can manage these execution patterns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"can manage" -> "could be used to manage"
|
|
||
| - **Object storage:** The input and output data can be stored in object storage, such as Amazon S3 or Google Cloud | ||
| Storage, which can be mounted as a persistent volume in the Kubernetes cluster. | ||
| - **Cloud sql:** The input and output data can be stored in cloud sql, such as Amazon RDS or Google Cloud SQL, which can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"sql"->"SQL"
|
|
||
| ## Cloud environment authentication | ||
|
|
||
| * Provider specific authentication guides here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to just make each cloud provider a separate sub-document given the amount of detail you might need to add
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just make this a YAML file instead of Markdown?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just make this a YAML file instead of Markdown?
| apiVersion: apps/v1 | ||
| kind: Deployment | ||
| metadata: | ||
| name: focus-converter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
provide a default namespace?
| spec: | ||
| containers: | ||
| - name: focus-converter | ||
| image: finopsfoundation/focus-converter:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are there requests and limits recommended?
| - ${OUTPUT_DIR} | ||
| - --data-format # use magic to read the headers, stdlib magic | ||
| - ${DATA_FORMAT} | ||
| volumes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if you want to provide a reference Filesystem-based PersistentVolume example or just link to the documentation, but there does need to be backing for this.
No description provided.