fix(publish): warn when push falls back from OCI 1.1 to OCI 1.0 - #14146
Open
htoyoda18 wants to merge 2 commits into
Open
fix(publish): warn when push falls back from OCI 1.1 to OCI 1.0#14146htoyoda18 wants to merge 2 commits into
htoyoda18 wants to merge 2 commits into
Conversation
Signed-off-by: hiroto.toyoda <hiroto.toyoda@dena.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
PushManifestsilently retried in OCI 1.0 format whenever a registry rejected the OCI 1.1 manifest, leaving users unaware their artifact wasn't stored in the newer format. This was left as a TODO becauseinternal/ociintentionally avoids importinglogrus.PushManifestnow reports which OCI version was actually used instead of just success/failure, andpkg/compose/publish(which already depends onlogrus) logs a warning when that differs from what was requested.Related issue
N/A
(not mandatory) A picture of a cute animal, if possible in relation to what you did
🐈🐈🐈