Skip to content

fix(hub-ui): reduce light dock panel glass opacity - #280

Merged
antfu merged 1 commit into
devframes:mainfrom
dvcolomban:codex/fix-hub-panel-transparency
Aug 21, 2026
Merged

fix(hub-ui): reduce light dock panel glass opacity#280
antfu merged 1 commit into
devframes:mainfrom
dvcolomban:codex/fix-hub-panel-transparency

Conversation

@dvcolomban

@dvcolomban dvcolomban commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

What changed

  • add a local bg-dock-glass material that uses the default glass tint in light mode and retains the existing 80% tint in dark mode
  • apply it to DockPanel and DockEdge, keeping their borders and shadows
  • leave the command palette, toasts, popovers, and other hub overlays unchanged
  • add patterned light and dark stories for both panel modes

Why

bg-glass:80 resolves to fully opaque white in light mode, hiding the inspected page. The default bg-glass material reduces that light tint to 65%, so underlying content remains visible through the existing blur.

In dark mode, the existing 80% #111 tint already provides the right separation and contrast. The local shortcut preserves it instead of adopting the default glass material's lower 50% dark opacity. Both schemes retain blur(7px) and use the design system's existing glass values.

Light theme

Before

Light theme before: opaque dock panel

After

Light theme after: 65% glass dock panel with blurred page accents visible beneath it

Dark theme

The dark comparison is intentionally visually stable: this change preserves the existing 80% dark material.

Before

Dark theme before: 80% glass dock panel

After

Dark theme after: retained 80% glass dock panel with blurred page accents visible beneath it

Verification

  • pnpm lint
  • pnpm knip
  • pnpm test
  • pnpm typecheck
  • pnpm build
  • computed floating and edge panel styles: 65% white in light mode, 80% #111 in dark mode, and blur(7px) in both

Refs #267

@vercel

vercel Bot commented Aug 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
devframe Skipped Skipped Aug 21, 2026 6:38pm
@dvcolomban
dvcolomban marked this pull request as ready for review August 21, 2026 17:23
Copilot AI lite review requested due to automatic review settings August 21, 2026 17:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates @devframes/hub-ui dock panel “material” to be background-free (transparent) while still separating the panel from the inspected page via backdrop blur, borders, and shadows, and adds Storybook coverage to verify the new look in both light/dark themes.

Changes:

  • Switch DockPanel and DockEdge from bg-glass:80 to bg-transparent backdrop-blur-7 while retaining border + shadow.
  • Add new light/dark “transparent material” Storybook stories for both dock modes (float panel + edge panel).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
packages/hub-ui/src/client/components/dock/DockPanel.vue Changes float-panel material to transparent + backdrop blur.
packages/hub-ui/src/client/components/dock/DockPanel.stories.ts Adds patterned light/dark stories to validate the new float-panel material.
packages/hub-ui/src/client/components/dock/DockEdge.vue Changes edge-panel material to transparent + backdrop blur.
packages/hub-ui/src/client/components/dock/DockEdge.stories.ts Adds patterned light/dark stories to validate the new edge-panel material.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread packages/hub-ui/src/client/components/dock/DockEdge.stories.ts
Comment thread packages/hub-ui/src/client/components/dock/DockPanel.stories.ts Outdated
Copilot AI review requested due to automatic review settings August 21, 2026 17:34
@dvcolomban
dvcolomban force-pushed the codex/fix-hub-panel-transparency branch from 383eec1 to 67af4ad Compare August 21, 2026 17:34
@dvcolomban
dvcolomban marked this pull request as draft August 21, 2026 17:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Suppressed comments (2)

packages/hub-ui/src/client/components/dock/DockEdge.stories.ts:150

  • The Story uses the utility class bg-grid-24, but that class/shortcut isn’t defined in this package’s UnoCSS config. As a result, the “patterned” background won’t render, making this story misleading for validating the new transparent material.
        ctx => h('div', { class: 'relative w-screen h-screen bg-secondary bg-grid-24' }, [

packages/hub-ui/src/client/components/dock/DockPanel.stories.ts:82

  • The Story uses the utility class bg-grid-24, but that class/shortcut isn’t defined in this package’s UnoCSS config. As a result, the “patterned” background won’t render, making this story misleading for validating the new transparent material.
        ctx => h('div', { class: 'relative w-screen h-screen bg-secondary bg-grid-24' }, [
@dvcolomban
dvcolomban force-pushed the codex/fix-hub-panel-transparency branch from 67af4ad to 4bbc557 Compare August 21, 2026 18:01
@dvcolomban
dvcolomban marked this pull request as ready for review August 21, 2026 18:05
Copilot AI review requested due to automatic review settings August 21, 2026 18:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings August 21, 2026 18:22
@dvcolomban
dvcolomban force-pushed the codex/fix-hub-panel-transparency branch from 4bbc557 to 26f2432 Compare August 21, 2026 18:22
@dvcolomban dvcolomban changed the title fix(hub-ui): make dock panels background-free Aug 21, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Comment thread packages/hub-ui/src/client/components/dock/DockPanel.vue Outdated
Comment thread packages/hub-ui/src/client/components/dock/DockEdge.vue Outdated
Copilot AI review requested due to automatic review settings August 21, 2026 18:38
@dvcolomban
dvcolomban force-pushed the codex/fix-hub-panel-transparency branch from 26f2432 to 6bee9c1 Compare August 21, 2026 18:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Comment thread packages/hub-ui/uno.config.ts
@dvcolomban dvcolomban changed the title fix(hub-ui): reduce dock panel glass opacity Aug 21, 2026
@antfu
antfu merged commit 887e637 into devframes:main Aug 21, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants