fix: resolve knip failures from plugin-git shiki refactor - #265
Merged
Conversation
- remove duplicate @devframes/service-shiki devDependency in plugins/git/package.json (already listed under dependencies) - drop the stale valibot ignoreDependencies entry in knip.jsonc; the spa-devframe.ts example that used it was removed in #234
✅ Deploy Preview for devfra ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Main's CI
unit-test / lintjob has been failing at theknipstep since #264 ("refactor(plugin-git): render diffs in-house via service-shiki"):@devframes/service-shikiwas listed as both adependenciesand adevDependenciesentry inplugins/git/package.json, tripping knip's unused-devDependency check.knip.jsonc's root-workspaceignoreDependencies: ["valibot"]exception (for the oldspa-devframe.tsexample) is stale — that file was deleted in refactor!: remove never-implemented SPA adapter remnants and other dead code #234, so the exception now just masks a config hint knip surfaces on every run.Changes
@devframes/service-shikifromplugins/git/package.json'sdevDependencies(it's already a real runtimedependenciesentry).valibotexception and its comment fromknip.jsonc.Verification
pnpm build && pnpm run lint && pnpm run knip— all green, matching CI'sbuild-for-lint: truesequencing.pnpm build && pnpm run typecheck— 37/37 packages pass.pnpm exec vitest run --project @devframes/plugin-git— 29/29 tests pass.Created with the help of an agent.