Make DCO workflow Probot compatible#8110
Open
tohtana wants to merge 1 commit into
Open
Conversation
Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current merge-queue-required DCO check does not match Probot DCO behavior. As a result, the required GitHub Actions DCO check can remain failing even after maintainers resolve the DCO status through the Probot DCO UI.
This PR makes the merge-queue-compatible required DCO workflow consistent with Probot DCO behavior: it skips merge commits and verified bot-authored commits, and it accepts a successful official Probot DCO check on the same PR head SHA.
It also renames the GitHub Actions check to
DCO / required, making it easier to distinguish the required merge-queue check from the ProbotDCOcheck.