Skip to content

fix(ci): accept branded AG-UI compatibility marker - #930

Merged
blove merged 1 commit into
mainfrom
blove/fix-ag-ui-compatibility-smoke
Sep 1, 2026
Merged

fix(ci): accept branded AG-UI compatibility marker#930
blove merged 1 commit into
mainfrom
blove/fix-ag-ui-compatibility-smoke

Conversation

@blove

@blove blove commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • accept the user-facing AG-UI ready label in packaged-consumer runtime smoke
  • preserve exact readiness checks for every other compatibility marker
  • update the regression test to cover the branded label

Why

#928 correctly normalized the visible marker from ag-ui ready to AG-UI ready, but the runtime smoke still derived its expected text from the machine identifier. Angular 20 and Angular 22 packaged-consumer jobs therefore failed after rendering the correct ready state.

Verification

  • node --test examples/chat/smoke/runtime-smoke.spec.mjs (17/17)
  • npx nx test scripts --skip-nx-cache
  • npx prettier --check examples/chat/smoke/runtime-smoke.mjs examples/chat/smoke/runtime-smoke.spec.mjs
  • git diff --check
@vercel

vercel Bot commented Sep 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
threadplane Ready Ready Preview Sep 1, 2026 6:29am UTC

Request Review

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated approval: this PR received an intelligent (AI) code review. See the review comments on this PR.

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Claude finished @blove's task in 0s —— View job


I'll analyze this and get back to you.

@blove
blove merged commit 14a9719 into main Sep 1, 2026
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant