fix(semantic layers): apply post-processing

[betodealmeida]

SUMMARY

Make sure we apply post-processing when exploring semantic views.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[netlify]

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	60a89cc
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/6a445c61a97ac000085abdef
😎 Deploy Preview	https://deploy-preview-41601--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.42%. Comparing base (805c12e) to head (60a89cc).
⚠️ Report is 10 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #41601      +/-   ##
==========================================
- Coverage   64.54%   64.42%   -0.13%     
==========================================
  Files        2665     2668       +3     
  Lines      146641   147200     +559     
  Branches    33880    33950      +70     
==========================================
+ Hits        94652    94833     +181     
- Misses      50271    50650     +379     
+ Partials     1718     1717       -1     

Flag	Coverage Δ
hive	39.10% <12.50%> (-0.07%)	⬇️
mysql	57.65% <12.50%> (-0.22%)	⬇️
postgres	57.71% <12.50%> (-0.22%)	⬇️
presto	40.65% <12.50%> (-0.09%)	⬇️
python	59.13% <100.00%> (-0.22%)	⬇️
sqlite	57.35% <12.50%> (-0.22%)	⬇️
unit	100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[bito-code-review]

Code Review Agent Run #086e6c

Actionable Suggestions - 0

Review Details

• Files reviewed - 2 · Commit Range: 60a89cc..60a89cc

  • superset/semantic_layers/models.py
  • tests/unit_tests/semantic_layers/models_test.py
• Files skipped - 0
• Tools

  • MyPy (Static Code Analysis) - ✔︎ Successful
  • Astral Ruff (Static Code Analysis) - ✔︎ Successful
  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[richardfogaca]

LGTM

[mikebridge]

Approve. This faithfully mirrors the dataset post-processing flow onto semantic views, with solid behavioral tests asserting real output and pinning the empty-DataFrame no-op. Nice work.

One minor note: at superset/semantic_layers/models.py:288, the dataset path calls normalize_df before exec_post_processing (superset/models/helpers.py:1698-1718); the semantic path runs post-processing directly on the get_results DataFrame with no normalization. Pure numeric ops (contribution) are fine, but typed operations (resample, rolling, prophet) could diverge. Could you confirm semantic-view DataFrames are normalized upstream — or add a short comment noting the divergence? Not merge-blocking.

This review was generated by Claude (AI) on behalf of @mikebridge.