Support constructing MessageId from results of send() and receive() - #254
Merged
BewareMyPower merged 1 commit intoMay 6, 2025
Merged
Conversation
Currently, `Producer.send` returns a `_pulsar.MessageId` instance, `Consumer.receive` returns a `MessageId` whose `message_id()` method returns a `_pulsar.MessageId` instance. This forces users to access the type from the C extension module (`_pulsar`). This patch adds a `MessageId.wrap` class method to convert the type from the C extension to the type in the `pulsar` module. It also exposes the comparison methods for `MessageId`.
shibd
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
Producer.sendreturns a_pulsar.MessageIdinstance,Consumer.receivereturns aMessageIdwhosemessage_id()method returns a_pulsar.MessageIdinstance. This forces users to access the type from the C extension module (_pulsar).This patch adds a
MessageId.wrapclass method to convert the type from the C extension to the type in thepulsarmodule. In addition, it exposes the comparison methods forMessageIdand allows accepting aMessageIdinstance foracknowledgeandacknowledge_cumulativemethods.