Support seek a MessageId from pulsar module - #233
Merged
BewareMyPower merged 1 commit intoJan 20, 2025
Conversation
BewareMyPower
marked this pull request as draft
December 11, 2024 14:17
BewareMyPower
force-pushed
the
bewaremypower/msg-id-compare
branch
from
January 18, 2025 13:53
4151fe9 to
71257dc
Compare
BewareMyPower
marked this pull request as ready for review
January 18, 2025 13:53
BewareMyPower
force-pushed
the
bewaremypower/msg-id-compare
branch
from
January 20, 2025 06:17
71257dc to
44c4f4e
Compare
RobertIndie
approved these changes
Jan 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
seekmethod ofConsumerorReadercan only accept theMessageIdfrom the_pulsarmodule, which is the underlying C extension that should not be exposed. If aMessageIdinstance from thepulsarmodule is passed as the argument, this method will fail.