Build the C extension with optimize options enabled - #230
Merged
merlimat merged 2 commits intoNov 1, 2024
Conversation
Contributor
Author
|
The CI seems broken. Let me open another PR to handle it. |
merlimat
approved these changes
Oct 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
CMAKE_BUILD_TYPEoption is not configured when building the C extension. With the default config, the compiler might not add optimization flags.After adding
CMAKE_BUILD_TYPE=Release, the total send time of 1000k messages reduced from 30s to 10s with the code example here and Python 3.8 on Ubuntu 20.4 container.