Fix incorrect logs when a message failed to be decoded with the writer schema - #200
Merged
BewareMyPower merged 1 commit intoFeb 19, 2024
Merged
Conversation
BewareMyPower
force-pushed
the
bewaremypower/fix-error-msg
branch
from
February 18, 2024 05:38
e47605a to
2940c60
Compare
shibd
approved these changes
Feb 18, 2024
Contributor
Author
|
It seems the main branch is broken. I will fix it first. |
BewareMyPower
marked this pull request as draft
February 18, 2024 13:01
…r schema ### Motivation See https://github.com/apache/pulsar-client-python/blob/f9b2d168ae85f289d6ee043cd81791d569ba8844/pulsar/schema/schema_avro.py#L92C32-L92C69 When `self._decode_bytes(msg.data(), writer_schema)` failed, the error log is still `Failed to get schema info`, which is confusing. ### Modifications Modify the error message. Even if it failed at `self._get_writer_schema(topic, version)`, there would still be error logs from the C++ client.
BewareMyPower
force-pushed
the
bewaremypower/fix-error-msg
branch
from
February 19, 2024 02:14
2940c60 to
7882506
Compare
BewareMyPower
marked this pull request as ready for review
February 19, 2024 02:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
See
https://github.com/apache/pulsar-client-python/blob/f9b2d168ae85f289d6ee043cd81791d569ba8844/pulsar/schema/schema_avro.py#L92C32-L92C69
When
self._decode_bytes(msg.data(), writer_schema)failed, the error log is stillFailed to get schema info, which is confusing.Modifications
Modify the error message. Even if it failed at
self._get_writer_schema(topic, version), there would still be error logs from the C++ client.