fix(@angular/build): prevent esbuild service hang on internal component stylesheet builds#33498
Open
clydin wants to merge 1 commit into
Open
fix(@angular/build): prevent esbuild service hang on internal component stylesheet builds#33498clydin wants to merge 1 commit into
clydin wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces an alwaysUseContext flag to BundlerContext to force the use of an esbuild build context, while falling back to a single build for non-incremental paths. The review feedback suggests checking if the context is disposed before and after performing a single build to prevent executing builds on a disposed context. Additionally, it is recommended to reorder the constructor parameters of BundlerContext so that alwaysUseContext comes before the optional initialFilter parameter, which simplifies instantiation by avoiding the need to pass undefined multiple times.
clydin
force-pushed
the
fix-ng-build-hang-33497
branch
from
6996d29 to
795037f
Compare
…nt stylesheet builds Switching to esbuild.context() + rebuild() for all builds in PR angular#33267 meant that all component stylesheet builds (which are separate BundlerContext instances) also created individual esbuild contexts. For builds with large amounts of stylesheets, this resulted in creating and concurrently disposing many esbuild contexts, leading to a timing deadlock/hang in the esbuild service child process. This change adds an alwaysUseContext parameter (defaulting to false) to BundlerContext to allow the main/global bundle contexts to continue using esbuild.context() (to ensure their plugins' onDispose callbacks run), while allowing component stylesheets to safely fall back to one-shot esbuild.build() during non-incremental/one-shot builds.
clydin
force-pushed
the
fix-ng-build-hang-33497
branch
from
795037f to
768cf13
Compare
clydin
added
the
action: review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching to esbuild.context() + rebuild() for all builds in PR #33267 meant that all component stylesheet builds (which are separate BundlerContext instances) also created individual esbuild contexts. For builds with large amounts of stylesheets, this resulted in creating and concurrently disposing many esbuild contexts, leading to a timing deadlock/hang in the esbuild service child process.
This change adds an alwaysUseContext parameter (defaulting to false) to BundlerContext to allow the main/global bundle contexts to continue using esbuild.context() (to ensure their plugins' onDispose callbacks run), while allowing component stylesheets to safely fall back to one-shot esbuild.build() during non-incremental/one-shot builds.