Skip to content

Revert "Enhance cache-dependency-path handling to support files outside the workspace root" - #1186

Merged
v-HarithaVattikuti merged 2 commits into
mainfrom
revert-1128-enhance-cache-dependency-path
Aug 28, 2025
Merged

Revert "Enhance cache-dependency-path handling to support files outside the workspace root"#1186
v-HarithaVattikuti merged 2 commits into
mainfrom
revert-1128-enhance-cache-dependency-path

Conversation

@aparnajyothi-y

Copy link
Copy Markdown
Contributor

This reverts commit 1264885.

Description:
Reverts PR #1128. That change copied a file from the composite action into the workspace to support composite actions, but we’ve decided to implement this capability at the actions/toolkit level instead (see actions/toolkit#1035) for a more consistent and scalable solution.

Copilot AI review requested due to automatic review settings August 26, 2025 06:33
@aparnajyothi-y
aparnajyothi-y requested a review from a team as a code owner August 26, 2025 06:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts commit 1264885 which enhanced cache-dependency-path handling to support files outside the workspace. The functionality is being reimplemented at the actions/toolkit level for better consistency across actions.

Key changes:

  • Removes complex file copying logic from the cacheDependencies function
  • Eliminates associated test coverage for the removed functionality
  • Removes documentation note about support for files outside workspace

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File Description
src/setup-python.ts Reverts cacheDependencies function to simpler implementation without file copying logic
docs/advanced-usage.md Removes documentation note about cache-dependency-path supporting files outside workspace
tests/setup-python.test.ts Removes all test cases for the reverted file copying functionality
.github/workflows/test-pypy.yml Adds windows-2019 to test matrix (unrelated change)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/setup-python.ts
@aparnajyothi-y aparnajyothi-y changed the title Revert "Enhance cache-dependency-path handling to support files outsi… Aug 26, 2025
@v-HarithaVattikuti
v-HarithaVattikuti merged commit 3d1e2d2 into main Aug 28, 2025
1299 checks passed
@v-HarithaVattikuti
v-HarithaVattikuti deleted the revert-1128-enhance-cache-dependency-path branch August 28, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants