Skip to content

fix: Added quotes to unquoted paths in python install and pip upgrade commands #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
franciscogarcia-payroc wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: Added quotes to unquoted paths in python install and pip upgrade commands #378

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
caa0ffb
Added backtick commented out quotes for pip upgrade steps to avoid pa…
franciscogarcia-payroc Mar 3, 2026
ae0097e
Added quoted paths for the python installation in the same fashion
franciscogarcia-payroc Mar 3, 2026
93b884f
Added quotes to ArchPath inside the Get-ExecParams function
franciscogarcia-payroc Mar 10, 2026
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions installers/win-setup-template.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,10 @@ function Get-ExecParams {
)

if ($IsMSI) {
"TARGETDIR=$PythonArchPath ALLUSERS=1"
"TARGETDIR=`"$PythonArchPath`" ALLUSERS=1"
} else {
$Include_freethreaded = if ($IsFreeThreaded) { "Include_freethreaded=1" } else { "" }
"DefaultAllUsersTargetDir=$PythonArchPath InstallAllUsers=1 $Include_freethreaded"
"DefaultAllUsersTargetDir=`"$PythonArchPath`" InstallAllUsers=1 $Include_freethreaded"
}
}

Expand Down Expand Up @@ -121,7 +121,7 @@ Copy-Item -Path ./$PythonExecName -Destination $PythonArchPath | Out-Null
Write-Host "Install Python $Version in $PythonToolcachePath..."
$ExecParams = Get-ExecParams -IsMSI $IsMSI -IsFreeThreaded $IsFreeThreaded -PythonArchPath $PythonArchPath

cmd.exe /c "cd $PythonArchPath && call $PythonExecName $ExecParams /quiet"
cmd.exe /c "cd `"$PythonArchPath`" && call `"$PythonExecName`" $ExecParams /quiet"
Comment thread
franciscogarcia-payroc marked this conversation as resolved.
if ($LASTEXITCODE -ne 0) {
Throw "Error happened during Python installation"
}
Expand All @@ -138,7 +138,7 @@ New-Item -Path "$PythonArchPath\python3.exe" -ItemType SymbolicLink -Value "$Pyt
Write-Host "Install and upgrade Pip"
$Env:PIP_ROOT_USER_ACTION = "ignore"
$PythonExePath = Join-Path -Path $PythonArchPath -ChildPath "python.exe"
cmd.exe /c "$PythonExePath -m ensurepip && $PythonExePath -m pip install --upgrade --force-reinstall pip --no-warn-script-location"
cmd.exe /c "`"$PythonExePath`" -m ensurepip && `"$PythonExePath`" -m pip install --upgrade --force-reinstall pip --no-warn-script-location"
Comment thread
franciscogarcia-payroc marked this conversation as resolved.
if ($LASTEXITCODE -ne 0) {
Throw "Error happened during pip installation / upgrade"
}
Expand Down
Loading