chore: update action versions - #267
Merged
Merged
Conversation
mayeut
marked this pull request as draft
May 4, 2024 13:36
mayeut
marked this pull request as ready for review
May 4, 2024 13:41
mayeut
force-pushed
the
update-actions
branch
2 times, most recently
from
May 9, 2024 14:19
3fae550 to
8e3775e
Compare
This removes Node.js 16 deprecation warnings
Contributor
Author
|
same weird failure as in #273, ubuntu 24.04 tests were not executed on the correct image: https://github.com/actions/python-versions/actions/runs/9035848592/job/24831831531#step:1:5 |
v-priya-kinthali
approved these changes
May 17, 2024
aparnajyothi-y
approved these changes
May 20, 2024
v-HarithaVattikuti
approved these changes
May 22, 2024
|
I believe there is some issue with the artifacts uploaded in the last release... see actions/setup-python#886 (comment) and the related issue actions/setup-python#886 IMO, the update of the upload-artifact action might have caused this (?) |
mayeut
added a commit
to mayeut/python-versions
that referenced
this pull request
Jun 10, 2024
actions#267 introduced a regression in asset upload. The layout of the artefacts to upload has changed. They're now all flatten in the working directory whereas before that PR, only the `hashes.sha256` file was directly in the working directory. The change in layout caused `.toString()` to be called on python archives which corrupts the data that gets uploaded (as can be seen by comparing sha256 in `hashes.sha256` with the ones from other uploaded assets). This commit ensures that a "flat layout" is used and that `toString()` is only called for `hashes.sha256`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes Node.js 16 deprecation warnings.