Skip to content

wp_die() updates for the Options component #9994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CallumBW95 wants to merge 4 commits into
base: trunk
Choose a base branch
from
+12 −10
Open

wp_die() updates for the Options component #9994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0251d5f
Update wp_die() to include status codes where appropriate within file…
CallumBW95 Sep 19, 2025
7ee878a
coding standards
CallumBW95 Sep 25, 2025
3e6f886
Merge branch 'trunk' of github.com:CallumBW95/wordpress-develop into …
CallumBW95 Sep 30, 2025
f282b27
status code update from 400 -> 403
CallumBW95 Oct 2, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/wp-admin/options-discussion.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
require_once __DIR__ . '/admin.php';

if ( ! current_user_can( 'manage_options' ) ) {
wp_die( __( 'Sorry, you are not allowed to manage options for this site.' ) );
wp_die( __( 'Sorry, you are not allowed to manage options for this site.' ), 403 );
}

// Used in the HTML title tag.
Expand Down
2 changes: 1 addition & 1 deletion src/wp-admin/options-general.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
require_once ABSPATH . 'wp-admin/includes/translation-install.php';

if ( ! current_user_can( 'manage_options' ) ) {
wp_die( __( 'Sorry, you are not allowed to manage options for this site.' ) );
wp_die( __( 'Sorry, you are not allowed to manage options for this site.' ), 403 );
}

// Used in the HTML title tag.
Expand Down
2 changes: 1 addition & 1 deletion src/wp-admin/options-media.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
require_once __DIR__ . '/admin.php';

if ( ! current_user_can( 'manage_options' ) ) {
wp_die( __( 'Sorry, you are not allowed to manage options for this site.' ) );
wp_die( __( 'Sorry, you are not allowed to manage options for this site.' ), 403 );
}

// Used in the HTML title tag.
Expand Down
2 changes: 1 addition & 1 deletion src/wp-admin/options-permalink.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
require_once __DIR__ . '/admin.php';

if ( ! current_user_can( 'manage_options' ) ) {
wp_die( __( 'Sorry, you are not allowed to manage options for this site.' ) );
wp_die( __( 'Sorry, you are not allowed to manage options for this site.' ), 403 );
}

// Used in the HTML title tag.
Expand Down
2 changes: 1 addition & 1 deletion src/wp-admin/options-privacy.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
require_once __DIR__ . '/admin.php';

if ( ! current_user_can( 'manage_privacy_options' ) ) {
wp_die( __( 'Sorry, you are not allowed to manage privacy options on this site.' ) );
wp_die( __( 'Sorry, you are not allowed to manage privacy options on this site.' ), 403 );
}

if ( isset( $_GET['tab'] ) && 'policyguide' === $_GET['tab'] ) {
Expand Down
2 changes: 1 addition & 1 deletion src/wp-admin/options-reading.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
require_once __DIR__ . '/admin.php';

if ( ! current_user_can( 'manage_options' ) ) {
wp_die( __( 'Sorry, you are not allowed to manage options for this site.' ) );
wp_die( __( 'Sorry, you are not allowed to manage options for this site.' ), 403 );
}

// Used in the HTML title tag.
Expand Down
2 changes: 1 addition & 1 deletion src/wp-admin/options-writing.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
require_once __DIR__ . '/admin.php';

if ( ! current_user_can( 'manage_options' ) ) {
wp_die( __( 'Sorry, you are not allowed to manage options for this site.' ) );
wp_die( __( 'Sorry, you are not allowed to manage options for this site.' ), 403 );
}

// Used in the HTML title tag.
Expand Down
5 changes: 3 additions & 2 deletions src/wp-admin/options.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,13 +251,14 @@
/* translators: %s: The options page name. */
__( '<strong>Error:</strong> The %s options page is not in the allowed options list.' ),
'<code>' . esc_html( $option_page ) . '</code>'
)
),
403
);
}

if ( 'options' === $option_page ) {
if ( is_multisite() && ! current_user_can( 'manage_network_options' ) ) {
wp_die( __( 'Sorry, you are not allowed to modify unregistered settings for this site.' ) );
wp_die( __( 'Sorry, you are not allowed to modify unregistered settings for this site.' ), 403 );
}
$options = isset( $_POST['page_options'] ) ? explode( ',', wp_unslash( $_POST['page_options'] ) ) : null;
} else {
Expand Down
3 changes: 2 additions & 1 deletion src/wp-includes/option.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,7 +570,8 @@ function wp_protect_special_option( $option ) {
/* translators: %s: Option name. */
__( '%s is a protected WP option and may not be modified' ),
esc_html( $option )
)
),
400
);
}
}
Expand Down
Loading