fix(docs): Prevent unhandled error for invalid library IDs in docs head() - #1207
Open
sentry[bot] wants to merge 1 commit into
Open
fix(docs): Prevent unhandled error for invalid library IDs in docs head()#1207sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | e525d95 | Commit Preview URL Branch Preview URL |
Aug 31 2026, 11:06 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where navigating to documentation URLs with invalid library IDs (e.g.,
/select/latest/...) resulted in an unhandled error during hydration, instead of a graceful 404.Root Cause:
The
head()function insrc/routes/_library/$libraryId/$version.docs.framework.$framework.$.tsxwas callinggetLibrary(libraryId). ThegetLibrary()utility throws an error if the providedlibraryIddoes not exist. While the parent route (/_library/$libraryId/route.tsx) correctly usesfindLibrary()and throwsnotFound()for invalid IDs, TanStack Router's hydration process still evaluates the child route'shead()function, leading to the unhandled error.Solution:
src/routes/_library/$libraryId/$version.docs.framework.$framework.$.tsxto includefindLibraryandnotFound.head()function in the same file to usefindLibrary(libraryId)instead ofgetLibrary(libraryId).findLibraryreturnsundefined(meaning the library was not found),throw notFound()is called. This aligns the behavior with sibling routes (e.g.,src/routes/_library/$libraryId/$version.docs.$.tsx) and ensures that invalid library IDs are handled gracefully, resulting in a proper 404 page.Fixes TANSTACK-COM-45W
This PR was automatically generated by Sentry. You can adjust this setting at any time.